search

faceyspacey / redux-first-router-link

<Link /> + <NavLink /> that mirror react-router's + a few additional props
MIT License
55 stars 33 forks source link

fix: middle mouse click in Firefox #93

Closed UberMouse closed 5 years ago

UberMouse commented 6 years ago

Fix middle mouse click events being prevented in Firefox

Fixes #94

UberMouse commented 6 years ago

bump @faceyspacey

ScriptedAlchemy commented 6 years ago

Does this cause any issues with chrome or IE?

Id place a check to see if the browser engine is Mozilla before, then have specific logic for it. Unless you are sure this will work in all browsers and its not attaching itself so a specific browser api. For example can a phone click on it?

Just bring safe before I approve

UberMouse commented 6 years ago

Hi,

I only tested it in Chrome and Firefox so can't comment on IE or Mobile. I don't have time to take a look at this atm (this is a problem we ran into at work) but I can revisit it in the near future when I do have time to check those cases.

ScriptedAlchemy commented 6 years ago

okay, ill test it and merge if there’s no issue. Just give me a day or two

UberMouse commented 6 years ago

Thanks a bunch :)

faceyspacey commented 6 years ago

We will add it to the next major version. But verification in those browsers would help.

UberMouse commented 6 years ago

Any update on this? Anything I can do? We're going to be forced to fork the library soon if we can't get this merged in which we would prefer not to do.

ScriptedAlchemy commented 6 years ago

Let me see whats possible, give me a few days <3

ScriptedAlchemy commented 5 years ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: