search

faceyspacey / redux-first-router-link

<Link /> + <NavLink /> that mirror react-router's + a few additional props
MIT License
55 stars 33 forks source link

Attempting to open a link in a new tab using middle mouse button does not work in Firefox #94

Closed UberMouse closed 5 years ago

UberMouse commented 6 years ago

In the latest version of Firefox as of writing (59.0.2) attempting to middle mouse click a <Link> to open the link in a new tab does nothing. In Chrome this correctly opens the link in a new tab.

The problem seems to stem from different behavior around running the onClick handler between Firefox and Chrome, in Chrome the handlePress.js function is not executed for a middle mouse click but it is for Firefox.

In Firefox this results in the default action of the click event being prevented which results in the action doing nothing. I've created a PR (#93) with a fix I've done locally that fixes it, I've only tested it in latest Firefox and Chrome, however.

UberMouse commented 6 years ago

bump @faceyspacey

ScriptedAlchemy commented 6 years ago

sorry for such delays here im picking up this project and will start releasing updates and patches, just as with RFR2

ScriptedAlchemy commented 5 years ago

:tada: This issue has been resolved in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: