Ensure that generated links include a hash where necessary

faceyspacey / redux-first-router-link

<Link /> + <NavLink /> that mirror react-router's + a few additional props

MIT License

55 stars 33 forks source link

Closed coulson84 closed 5 years ago

coulson84 commented 6 years ago

If using createHashHistory as a custom option instead of browserHistory then the links generated by the package would be incorrect.

By passing the path via history.createHref({ pathname: path }) it ensures that, when using hashHistory, then there is a # prepended to the path.

ScriptedAlchemy commented 5 years ago

@coulson84 please fix merge conflicts, update tests and I’ll merge it. Apologies for the delay

This is for RFR2

ScriptedAlchemy commented 5 years ago

@coulson84 bumping this cause I know it’s old