search

facn2 / facnrecipe

simple recipe application for facn community
0 stars 2 forks source link

router.js and handlers.js #40

Open jwld opened 7 years ago

jwld commented 7 years ago

You should move as much code as possible from router.js to handlers.js - the router should just be a few lines connecting the urls to the handler functions. You've got one handler function, but all the code for the other endpoints should be in the handlers file too ideally :)

tyeung2017 commented 7 years ago

A sad story: Some random Hong Kong guy tried to refactor his code and add tests 10mins before the code review.

He did a good job in refactoring and fixing bugs, all was well; and then he fucked up the git flow and all the changes are gone.