factorial-io / phabalicious

Supports your deployments and every-day devops-tasks
http://docs.phab.io
MIT License
18 stars 3 forks source link

Add support for `deploy`-command from drush 10.3 #119

Closed stmh closed 3 years ago

stmh commented 3 years ago

This small change will add support for drush's deploy-command and its hook-system.

Closing #106

mikran commented 3 years ago

Looks good, but I think phabalicious should also adopt the drush standardized way to run database updates. Deploy process is now identical except this one part.

currently phabalicious is doing this:

$this->runDrush($shell, 'cr -y');
$this->runDrush($shell, 'updb -y');

and drush deploy standard is:

drush updatedb --no-cache-clear
drush cache:rebuild

Doing cr before updb and doing updb with --no-cache-clear are most likely a solution to same problem. But I can see cases where the --no-cache-clear is better. Doing cr before updb can lead to some errors that then get resolved by the subsequent cr.

stmh commented 3 years ago

lets try it out :)

stmh commented 3 years ago

@mikran please review