search

factorial-io / phabalicious

Supports your deployments and every-day devops-tasks
http://docs.phab.io
MIT License
18 stars 3 forks source link

Remove double --namespace from k8s methods #140

Closed mikran closed 3 years ago

mikran commented 3 years ago

The --namespace is added twice to the kubectl method and the second time comes after the command. This makes passing parameters to commands impossible. For example

phab --config=CONFIG k8s kubectl -- exec POD -- ls -la

is

kubectl ... --namespace NAMESPACE exec POD -- ls -la --namespace NAMESPACE
stmh commented 3 years ago

thanks for the fix. How time-critical is this fix? Maybe it makes sense to create a new 3.5.x release. 3.6 needs some more testing...

mikran commented 3 years ago

It is not critical, I'm fine using my fork for now

stmh commented 3 years ago

released with beta.6