factorial-io / phabalicious

Supports your deployments and every-day devops-tasks
http://docs.phab.io
MIT License
18 stars 3 forks source link

Uses @factorial/docs instead of vuepress #286

Closed mgrsskls closed 1 year ago

mgrsskls commented 1 year ago

This PR implements https://www.npmjs.com/package/@factorial/docs instead of Vuepress.

Please note:

Btw for SEO purposes it would be good if every page had a meta description. This can be done via meta_description in the front matter.

stmh commented 1 year ago

Hi @mgrsskls this looks great!

I notice that I do not have images when I run it locally, they are missing from the front page and all svgs of the blog-posts are also missing. Do I need to change the setup somehow?

I changed the package.json, so it yarn docs:dev works using localhost for the sitemap, please review.

mgrsskls commented 1 year ago

Hi @mgrsskls this looks great!

I notice that I do not have images when I run it locally, they are missing from the front page and all svgs of the blog-posts are also missing. Do I need to change the setup somehow?

Nope, sorry, my bad. When you pull and run yarn again, it should be fixed.

I changed the package.json, so it yarn docs:dev works using localhost for the sitemap, please review.

Oh, yeah, good point. But the port should be added, shouldn't it? Or is there a reason you did not add it?