fahrenfort / ADAM

the Amsterdam Decoding And Modeling (ADAM) toolbox
Other
37 stars 15 forks source link

Multiplot limited to 12 plots per figure #146

Closed ChristineBlume closed 3 years ago

ChristineBlume commented 3 years ago

When plotting temporal generalisation matrices, line 221 in adam_plot_MVPA seems to limit the number of plots to 12. This only happens when a plot order is specified, although when plotting temporal generalisation matrices, the line_colors argument does not seem relevant.

fahrenfort commented 3 years ago

True. Do you want to plot more than 12 temporal generalization matrices in a single figure? Seems excessive ;-) but I’ll update the code to allow that if you want...

On 27 Apr 2021, at 16:35, Christine Blume @.***> wrote:

When plotting temporal generalisation matrices, line 221 in adam_plot_MVPA seems to limit the number of plots to 12. This only happens when a plot order is specified, although when plotting temporal generalisation matrices, the line_colors argument does not seem relevant.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fahrenfort/ADAM/issues/146, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM6ZIBYB4INXKOFUBIYKDLTK3DRZANCNFSM43VD5T2Q.

ChristineBlume commented 3 years ago

Thanks so much. I am working in sleep research and we have 5 sleep stages, so you always end up with an excessive 5x5 matrix ;-). For now, I have adapted the code myself to circumvent the error message (and anyway will have to build a figure from individual plots eventually). If you have time and it's not a major thing, I think it could be helpful though. Thanks a ton!

fahrenfort commented 3 years ago

Ah OK! I have updated the code so that this restriction does not count for temporal generalization matrices. I haven’t checked yet whether it works properly, but feel free to try, download from here: Download ZIP https://github.com/fahrenfort/ADAM/archive/refs/heads/master.zip

On 28 Apr 2021, at 10:15, Christine Blume @.***> wrote:

Thanks so much. I am working in sleep research and we have 5 sleep stages, so you always end up with an excessive 5x5 matrix ;-). For now, I have adapted the code myself to circumvent the error message (and anyway will have to build a figure from individual plots eventually). If you have time and it's not a major thing, I think it could be helpful though. Thanks a ton!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fahrenfort/ADAM/issues/146#issuecomment-828251093, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM6ZIAVF6SNBGTZLMHTT6DTK6725ANCNFSM43VD5T2Q.

ChristineBlume commented 3 years ago

It works! :) Thanks a ton!