search

faiface / pixel

A hand-crafted 2D game library in Go
MIT License
4.46k stars 246 forks source link

Curves #266

Open jakubDoka opened 4 years ago

jakubDoka commented 4 years ago

This commit adds beizer curves to geometry and also adds one method for vector Angle to. Its all documentated. Curve should be used by a particle system i am planing to pull request.

bcvery1 commented 4 years ago

Why no tests?

Not sure why you're returning a pointer for B, Linear or Constant and why you have a pointer receiver for Point, the rest of the file is entirely functional with no pointer returns or receivers

jakubDoka commented 4 years ago

Ok i ll make some test just for sake of it. Lets remove these pointers then.

dusk125 commented 3 years ago

The Bezier functions/structures look good, was there a reason why you needed to change the pixelgl.Window structure to directly embed the glfh.Window structure?

@jakubDoka

duysqubix commented 1 year ago

@dusk125

I assume this PR is not relevant anymore.

dusk125 commented 1 year ago

@duysqubix could still be useful, I would suggest we revert the window.go changes. But other than those, lgtm

duysqubix commented 1 year ago

@dusk125

I am going to recreate this PR in pixel2 to track and modify changes there.

Update: PR merged with Pixel2