fangli / kibana-authentication-proxy

Hosts the latest kibana3 and elasticsearch behind Google OAuth2, Basic Authentication or CAS Authentication
MIT License
223 stars 66 forks source link

* added option to place user/password combinations in flatfile #18

Open strima opened 10 years ago

strima commented 10 years ago
fangli commented 10 years ago

Placing user/password separated is really a good feature, but I will not merge the base_path because it's not so necessary in most common cases. just want to keep it simple.

Thanks for your efforts:)

strima commented 10 years ago

and if i do something like that:

if (!config.base_path) { config.base_path=""; }

then it would be ok if this option is not specified, but for others that want/need it it would still be there

what do you think ?

fangli commented 10 years ago

Good that's perfect.

BTW, Could you please add the basic_auth_file section and its description into config.js? so that I can merge the features easily. Default value of basic_auth_file should be ""[empty], and If it's specific, the content in this file will take place of basic_auth_users.

Thanks.

strima commented 10 years ago

done as proposed. hope it's ok now.

btw, i adopted the whole thing for grafana. see https://github.com/strima/grafana-authentication-proxy

hope that's ok - i mentioned this project of course as base

fangli commented 10 years ago

Never mind, you are welcomed to fork or adopt as you go. it's helpful to the community, thank you :) I'll merge the pull request later, after performed a few tests.

strima commented 10 years ago

hi, as written in the config.js and readme.md i added an option for user based regex filtering of elasticsearch indizes, thus enabling some kind of authorization.

can be used eg. for restricting certain users to certain logstash indizes - thus not seeing all logs only the ones which are relevant for the user

strima commented 9 years ago

@fangli : did you already have time to do your tests ?