farhadi / node-smpp

SMPP client and server implementation in node.js
MIT License
419 stars 180 forks source link

Client & Server debug feature implementation #184

Closed rmruano closed 3 years ago

rmruano commented 3 years ago

Not having debug information makes it very difficult to debug communication issues between client & server.

This PR implements a pretty standard debug log that can be activated with a simple debug: true option. By default, the debug log is disabled, there won't be any output to stdout.

Additionally, the session object emits debug events in both client & server (even with the debug option disabled)

Tests to check the debug events have been written. Also, some new tests to perform client/server simulations are included.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+1.3%) to 78.67% when pulling 4e1feb255b7986fc70a38675e63622c4545cf376 on rmruano:feature/debug into eabd32dbbb6947493919f9e36b3b7926727cb570 on farhadi:master.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+1.2%) to 78.611% when pulling 44b1fe0a018cc2a6b8d29c1d3bfd0a664566d16c on rmruano:feature/debug into eabd32dbbb6947493919f9e36b3b7926727cb570 on farhadi:master.