farhadi / node-smpp

SMPP client and server implementation in node.js
MIT License
419 stars 180 forks source link

Update lib/defs.js types.cstring #193

Closed 0LEG0 closed 3 years ago

0LEG0 commented 3 years ago

Prevents a crash when a сstring PDU filed contains a value of a different type. For example, if the address field contains a number.

0LEG0 commented 3 years ago

Now without syntactic sugar

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 80.129% when pulling 79a098043646d361c4fc4e953c9dfbbe44bc4485 on 0LEG0:master into 1c5a4c22b801ec55713dc2ae83a79b04f8cee550 on farhadi:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 80.129% when pulling cec61c693ddb639ba195384eb924407be42ce85b on 0LEG0:master into 1c5a4c22b801ec55713dc2ae83a79b04f8cee550 on farhadi:master.

juliangut commented 3 years ago

Great, merging this for 0.6.0