search

farhadi / node-smpp

SMPP client and server implementation in node.js
MIT License
419 stars 180 forks source link

Close callback called too early #200

Closed peter-vasarhelyi closed 2 years ago

peter-vasarhelyi commented 2 years ago

Hello!

When I call the Session.close method with a callback, I think it is called too early (immediately). I believe the bug lies here: https://github.com/farhadi/node-smpp/blob/master/lib/smpp.js#L237 When I negate the condition it works properly. The same applies to the destroy function

ajamous commented 2 years ago

Thanks @peter-vasarhelyi , do you think this can lead to #205 ?

juliangut commented 2 years ago

The PR has been merged