search

farhadi / node-smpp

SMPP client and server implementation in node.js
MIT License
417 stars 177 forks source link

Transitive dependency to GPLv3 package findhit-util #214

Open TjlHope opened 2 years ago

TjlHope commented 2 years ago

Hi, we're looking to use this lib in a commercial project, and whilst checking the licenses noticed that node-smpp depends on findhit-proxywrap (BSD) which depends on findhit-util (GPLv3), meaning any derivative works need to be GPLv3 as well.

I've opened cusspvz/proxywrap#36 to see about removing that dep, but if that's not possible would you be open to a PR switching to a fork that removes the GPLv3 dep?

juliangut commented 2 years ago

Hi @TjlHope

Thanks for your work on proxywrap in order to avoid GPL3 license. Lets keep this issue open until your PR is merged

Again, thank you

TjlHope commented 2 years ago

Hi @juliangut

The PR's been merged cusspvz/proxywrap#37 and released to npm as findhit-proxywrap@0.3.13

Would it be possible to get a new patch version of node-smpp pushed out with the findhit-proxywrap dep bumped to ^0.3.13 so there's no risk of pulling in the old GPL version?

LMK if a PR would help in any way.

Thanks!

juliangut commented 2 years ago

Hi @TjlHope

please, if you have the time prepare a PR with the proper version so we can make a new release with the change