search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
1.81k stars 92 forks source link

Audio Visualiser freezes #121

Closed OrangeZXZ closed 8 months ago

OrangeZXZ commented 9 months ago

Steps to reproduce the bug

Use the Audio Visualiser

Expected behavior

The Audio Visualiser sould keep playing

Actual behavior

The Audio Visualiser freezes

Screenshots/Screen recordings

https://github.com/fast4x/RiMusic/assets/104271365/835a8858-0db3-45cf-a649-22c9f756c352

Logs

No response

RiMusic version

0.6.9

Android version

Android 13 with One UI 5.1

Additional information

Also the background should be black like the lirics And the Visualiser would be nice to change colors in Dynamic mode. And to finish instead of using the microphone it would be bether to use the music cached db

fast4x commented 9 months ago

uhm I can see if possible with the current development version

Freeze are bug probably

OrangeZXZ commented 9 months ago

The bug is less present on android 14 with one UI 6

fast4x commented 9 months ago

The strange thing is that in the android emulator 13/14, the bug is not present.

NEVARLeVrai commented 9 months ago

The strange thing is that in the android emulator 13/14, the bug is not present.

I have also the issue on Android 12 MIUI 14

OrangeZXZ commented 9 months ago

The strange thing is that in the android emulator 13/14, the bug is not present.

Maybe it's my phone that has a problem. Il try on other samsung devices that my family has.

fast4x commented 9 months ago

The bug is there, even on my phone, the strange thing is that I can’t play it in the android emulator.

OrangeZXZ commented 9 months ago

The bug is there, even on my phone, the strange thing is that I can’t play it in the android emulator.

I think the phone security or something like that blocks because the app is from an "unknown person" maybe in the emulator the security works differently

fast4x commented 9 months ago

Sure could be, I have to investigate, if you find any info let me know

OrangeZXZ commented 9 months ago

Sure could be, I have to investigate, if you find any info let me know

Oh i think i found it my phone doesn't say that the mike is used I don't know how it works but it needs mike privileges so i think this is the problem

![Uploading Screenshot_20231121_074619_Permission usage.jpg …]()

NEVARLeVrai commented 9 months ago

Sure could be, I have to investigate, if you find any info let me know

Oh i think i found it my phone doesn't say that the mike is used I don't know how it works but it needs mike privileges so i think this is the problem

![Uploading Screenshot_20231121_074619_Permission usage.jpg …]()

Ur screenshot don't work

NEVARLeVrai commented 9 months ago

Sure could be, I have to investigate, if you find any info let me know

Oh i think i found it my phone doesn't say that the mike is used I don't know how it works but it needs mike privileges so i think this is the problem

![Uploading Screenshot_20231121_074619_Permission usage.jpg …]()

Same, I don't see green microphones pop up for the mic, like the mic it's not used

fast4x commented 9 months ago

uhm but the permissions are set as required. Check

OrangeZXZ commented 9 months ago

uhm but the permissions are set as required. Check

I got an idea try using the share screen option in the update to see if it works but if it still freezing then there is an error elsewhere

fast4x commented 9 months ago

Today try ti get mic permission with another mode... Thanks for suggestions

fast4x commented 9 months ago

Have you tryed add mic permission manually?

OrangeZXZ commented 9 months ago

Have you tryed add mic permission manually?

yeah i did that

fast4x commented 9 months ago

Have you tryed add mic permission manually?

yeah i did that

And bug?

NEVARLeVrai commented 9 months ago

Have you tryed add mic permission manually?

yeah i did that

And bug?

ys

OrangeZXZ commented 9 months ago

I played with my audio visualiser and i noticed that randomly he wasn't freezing but just after I taped the download button it started freezing:

Also it dose it when you skip songs:

Also it bugs less when songs take less space and wen listening to music videos:

To finish it bugs less when listening to newer songs (not sure) and half of it disappears behind the image i think (maybe create a new layer for it) or could be a issue in the code (who knows it flashes sometimes and freezes when "there is no audio"

Edit: i just tried opening less overlaing menus and it bugs less

OrangeZXZ commented 9 months ago

Oh there is an extra space in there: image

OrangeZXZ commented 9 months ago

I played with my audio visualiser and i noticed that randomly he wasn't freezing but just after I taped the download button it started freezing:

  • Could be because there are back processes that make it freez (downloading cache)

Also it dose it when you skip songs:

  • Maybe because it loads the images (maybe try disabling images in the debuging process)

Also it bugs less when songs take less space and wen listening to music videos:

  • Maybe the cache that is loaded IRT (maybe loading directly the full song is a good option if this is not the case)

To finish it bugs less when listening to newer songs (not sure) and half of it disappears behind the image i think (maybe create a new layer for it) or could be a issue in the code (who knows it flashes sometimes and freezes when "there is no audio"

Edit: i just tried opening less overlaing menus and it bugs less

Forget everything i said here! I found a patch!

After using the app for a bit my phone randomly runed the app at 10 - 25 fps (because it was too hot) and studently the Visualiser worked perfectly until i restarted the app to get my 120hz back

I think à patch to this is to make the Visualiser run at 25 fps or lower (temporarily until there is an better option)

fast4x commented 9 months ago

That’s very good news, thanks for your help!

fast4x commented 9 months ago

Fixed, available from version 0.6.11

fast4x commented 8 months ago

A this moment no other work is possible, in the future i'll try other solutions.

NEVARLeVrai commented 8 months ago

A this moment no other work is possible, in the future i'll try other solutions.

Still freezing after a while in 60hz or 144hz

OrangeZXZ commented 8 months ago

Still freezing after a while in 60hz or 144hz

it is freezing less but we dont have a choise for now

fast4x commented 8 months ago

In the future I would like to use a different solution in the hope that it will be more stable

OrangeZXZ commented 8 months ago

In the future I would like to use a different solution in the hope that it will be more stable

I like the news choices that you've added (some are a bit too colored and misplaced but it is nice to have)