search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.37k stars 123 forks source link

Download with quality preference #1721

Open jrahme10 opened 5 months ago

jrahme10 commented 5 months ago

Steps to reproduce the bug

navigate to a playlist and download all tracks

Expected behavior

it should download all the tracks

Actual behavior

many of the tracks stuck at pending status

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.32

Android version

android 14

Additional information

No response

fast4x commented 5 months ago

Set audio quality low and try again

fast4x commented 5 months ago

Tested and for me it work nice

jrahme10 commented 5 months ago

Thank youu

ffuuuuu commented 2 weeks ago

Set audio quality low and try again

@fast4x Where to set that audio quality? And will it set all downloads to low quality? I also have some songs on some albums that won't download. Wouldn't it make more sense to download them in whatever quality is available without setting everything to low?

fast4x commented 2 weeks ago

Audio quality is available from next version 0.6.56

ffuuuuu commented 2 weeks ago

Audio quality is available from next version 0.6.56

@fast4x so does the setting download everything in low quality then? As I said wouldn't it make more sense to have a setting like 'prefer high quality' and when this ain't available to just automatically grab the lower quality version?

fast4x commented 2 weeks ago

Auto grab max quality, set low if you want lower quality, but not always available...

ffuuuuu commented 2 weeks ago

Auto grab max quality, set low if you want lower quality, but not always available...

@fast4x thanks for the clarification. That makes sense. Hopefully it works well. Was really struggling to get this working as some songs wouldn't download, even manually. Hope this'll fix it.

fast4x commented 2 weeks ago

I could implement an automatic mode with preference on maximum or minimum quality as user prefer... it would be ok?

ffuuuuu commented 2 weeks ago

I could implement an automatic mode with preference on maximum or minimum quality as user prefer... it would be ok?

@fast4x that'd be the best option and it should be default. As right now as I said even though you marked it as 'not a bug' some songs just aren't downloading no matter what you do.

fast4x commented 2 weeks ago

ok

ffuuuuu commented 1 week ago

ok

@fast4x tried the automatic setting with the latest release v0.6.56.1 and it still won't download everything. It somehow is even more unreliable than before. As it hangs with the ⏳ symbol with most songs. Can you reproduce this behavior?

ffuuuuu commented 1 week ago

@fast4x v0.6.57 fixed this issue. Only issue now is explicit songs still can't be downloaded.