fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
1.26k stars 71 forks source link

Use saved lyrics if available #1816

Open aneesh1122 opened 1 month ago

aneesh1122 commented 1 month ago

Description

I have songs downloaded in my device with lyrics in the same folder. RiMusic doesn't use those lyrics, it instead fetches lyrics online

Suggested Solution

Please use saved lyrics if available before fetching lyrics online

Alternatives

No response

Additional Context

No response

fast4x commented 1 month ago

you mean songs externally RiMusic?

fast4x commented 1 month ago

add here a lyrics file sample

aneesh1122 commented 1 month ago

you mean songs externally RiMusic?

Screenshot_2024-05-10-17-31-12-087_nextapp.fx-edit.jpg

In a folder I have this song and lyrics file .lrc with the same name.

aneesh1122 commented 1 month ago

add here a lyrics file sample

Lyrics example.zip

Uploaded both the song and its lyrics .lrc file

fast4x commented 1 month ago

ok thanks I'll check it

aneesh1122 commented 1 month ago

ok thanks I'll check it

Hey fast4x, I just observed something. If you open my uploaded song in mediainfo, vlc, mp3tag or any other app which shows metadata, you will see that the lyric is already embedded in the file.

could you please implement reading the embedded lyrics too?

fast4x commented 1 month ago

interesting I'll check it, thanks

aneesh1122 commented 1 month ago

interesting I'll check it, thanks

https://github.com/fast4x/RiMusic/assets/45353488/cba7e776-d777-4f57-9808-8f896499f5e0

the embedded lyrics in the song

Wjxfi commented 1 week ago

For completeness of offline mode, it has to do with this sweet cake :3 https://github.com/fast4x/RiMusic/issues/2385