fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.11k stars 109 forks source link

[Feature]: Importing songs to 'Favorites' #1955

Open aneesh1122 opened 4 months ago

aneesh1122 commented 4 months ago

Description

So I finally transferred my liked songs from spotify to RiMusic and I wanted to transfer those songs to my RiMusic 'Favorites'.

Suggested Solution

Treat 'Favourites' as a playlist where you can import/add songs into it or export songs to an another playlist. Basically how songs can be added to/from different playlists.

Alternatives

No response

Additional Context

No response

fast4x commented 4 months ago

Export favourites it's just released

aneesh1122 commented 4 months ago

Export favourites it's just released

I want to add multiple songs to favorites at once

aneesh1122 commented 4 months ago

Export favourites it's just released

Add 'Favorites' Above 'Pinned Playlists' like this new list

and when the song is already in 'Favorites' show it like this new list 2

fast4x commented 4 months ago

Would can also do this without using playlist logic. You select the songs and mark them as your favorite.

aneesh1122 commented 4 months ago

Would can also do this without using playlist logic. You select the songs and mark them as your favorite.

That will also be good but right now select/deselect is not working #1813

There is also no option to select all.

fast4x commented 4 months ago

Would can also do this without using playlist logic. You select the songs and mark them as your favorite.

That will also be good but right now select/deselect is not working #1813

There is also no option to select all.

be quiet I'll fix it

dAtA-TRoN commented 4 months ago

Would can also do this without using playlist logic. You select the songs and mark them as your favorite.

Best way to do it, in my opinion. Favourites should not behaving like any other playlist. It's more of an 'on the fly' thing. Otherwise this feature becomes redundant.

aneesh1122 commented 4 months ago

Would can also do this without using playlist logic. You select the songs and mark them as your favorite.

Best way to do it, in my opinion. Favourites should not behaving like any other playlist. It's more of an 'on the fly' thing. Otherwise this feature becomes redundant.

Spotify doesn't agree with you.

Now you may ask why do I want to transfer multiple songs to my 'Favorites'. It's because playlists are limited to 5000 songs whereas favorites are unlimited.

I'm not going to force fast4x to add something he doesn't want to but I disagree that 'Favorites' shouldn't be used as one of the playlists. As a user we should have full control over our collection, including favorites.

BTW what do you mean by "feature becomes redundant"? Who's stopping you from still using it as an "on the fly" thing?

dAtA-TRoN commented 4 months ago

Spotify doesn't agree with you.

Bullshit. I already agreed with fast4x position. And which of your mentioned points does he not address in his response!?

It's because playlists are limited to 5000 songs whereas favorites are unlimited.

Then it would be much more logical to lift the limit of the other playlists rather than going through the detour of the favorites list. Don't you agree?

BTW what do you mean by "feature becomes redundant"? Who's stopping you from still using it as an "on the fly" thing?

Nobody. But you water down the feature beyond recognition with that. Why would you need an extra favorites list then if any other playlist could do the job just as well? That's what I mean by redundant.

aneesh1122 commented 4 months ago

I already agreed with fast4x position

so did I because he is the developer of this app and he knows best. I still think it's completely logical to consider 'Favorites' as one of the playlists since it's a part of our collections.

Then it would be much more logical to lift the limit of the other playlists rather than going through the detour of the favorites list And why would you need an extra favorites list then if any other playlist could do the job just as well? That's what I mean by redundant.

It's much easier to add songs to 'Favorites'. Can be done from notification bar or from player so it's very convenient. It's also unlimited. It can be my ultimate collection.

I have like 1500 songs imported from spotify and I want to add them in my favorites list. I also want the freedom to delete multiple songs from favorites if I wish to do so. Right now I have to open every song in player and unlike.

all these problems can be solved if 'favorites' is treated as one of the playlists like spotify does.

As I said, I'll agree with fast4x's final decision because he knows best. I don't have to agree with you though.

dAtA-TRoN commented 4 months ago

I don't have to agree with you though.

You do it automatically, because like you, I stand behind what fast4x said.

aneesh1122 commented 4 months ago

I don't have to agree with you though.

You do it automatically, because like you, I stand behind what fast4x said.

Well, whatever helps you sleep at night

fast4x commented 4 months ago

My point of view is this: in the new logic of RiMusic the list of favorite songs is a section of the general list of songs. The structural changes of the next version are so many and deep that I can not focus on anything else at the moment.

On one thing I’m sure though, expanding the functionality of favorite songs is an opportunity and so also importing songs into specific sections is a good opportunity.

Favorite songs can’t be treated like a playlist but having a number of features that help manage them better I find it an opportunity for RiMusic.

aneesh1122 commented 4 months ago

My point of view is this: in the new logic of RiMusic the list of favorite songs is a section of the general list of songs. The structural changes of the next version are so many and deep that I can not focus on anything else at the moment.

On one thing I’m sure though, expanding the functionality of favorite songs is an opportunity and so also importing songs into specific sections is a good opportunity.

Favorite songs can’t be treated like a playlist but having a number of features that help manage them better I find it an opportunity for RiMusic.

I'm not in hurry so please concentrate on the new changes you are implementing right now.

When you're done changing things, start changing favorites.

dAtA-TRoN commented 4 months ago

Favorite songs can’t be treated like a playlist but having a number of features that help manage them better I find it an opportunity for RiMusic.

Nicely summarized 😗👌🏼!

fast4x commented 4 months ago

And meanwhile...

https://github.com/fast4x/RiMusic/assets/1484476/b777632e-6ff8-4f93-b52b-50de9d2daa5e

fast4x commented 4 months ago

https://github.com/fast4x/RiMusic/assets/1484476/d16fc333-eff6-45c3-8ece-a4f1f477de6c

aneesh1122 commented 4 months ago

https://github.com/fast4x/RiMusic/assets/1484476/d16fc333-eff6-45c3-8ece-a4f1f477de6c

Hey man, I got a new idea and I think you'll like it too. Should I post it here or create a new issue about it?

fast4x commented 4 months ago

Screen_recording_20240524_092955.mp4

Hey man, I got a new idea and I think you'll like it too. Should I post it here or create a new issue about it?

Hi, new specific...

aneesh1122 commented 4 months ago

Screen_recording_20240524_092955.mp4

Hey man, I got a new idea and I think you'll like it too. Should I post it here or create a new issue about it?

Hi, new specific...

On it