fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
1.97k stars 100 forks source link

[BUG] Theme changes to pitch black when changing settings when using material you theme #1976

Open privacyfreak84 opened 3 months ago

privacyfreak84 commented 3 months ago

Duplicate of #1699, as that seems to have gotten no attention.

Steps to reproduce the bug

  1. Have dark mode enabled (not pitch black!)
  2. Go to settings
  3. Change, for example, navigation bar position
  4. Theme changes to pitch black

Expected behavior

The setting should change without changing the theme

Actual behavior

The theme changes

Screenshots/Screen recordings

https://github.com/fast4x/RiMusic/assets/90613992/4c752971-7e42-4e5d-9142-108fc4820d7c

Logs

No response

RiMusic version

0.6.32

Android version

Android 11

Additional information

I think this happens with many more settings, not just the ones I showcased

Cszyn commented 3 months ago

fixed. update to 35

Cszyn commented 3 months ago

fixed. update to 35

Update to v 0.6.35

privacyfreak84 commented 3 months ago

Issue still occurs

Cszyn commented 3 months ago

Issue still occurs

that's weird, the issue is gone on my end. Mind telling me the phone manufacturer/ android fork?

Cszyn commented 3 months ago

EMUI/Huawei?

privacyfreak84 commented 3 months ago

Samsung, One UI

Cszyn commented 3 months ago

I'll fire up an emulator and see, but it does not occur in Xiaomi HyperOS

Cszyn commented 3 months ago

I'll fire up an emulator and see, but it does not occur in Xiaomi HyperOS

But it did happen on my Huawei p30 lite back in v6.32

privacyfreak84 commented 3 months ago

Also, the issue didn't occur a few months ago

Cszyn commented 3 months ago

Also, the issue didn't occur a few months ago

Latest One ui?

privacyfreak84 commented 3 months ago

No, One UI version 3.1

Cszyn commented 3 months ago

I'll fire up an emulator and see, but it does not occur in Xiaomi HyperOS

I'll take that comment back. It still occurs on my Xiaomi 14 and MuMu emulator running android 14 and 12 respectably.

aneesh1122 commented 3 months ago

I'll fire up an emulator and see, but it does not occur in Xiaomi HyperOS

I'll take that comment back. It still occurs on my Xiaomi 14 and MuMu emulator running android 14 and 12 respectably.

It happens only when you select 'material you' as theme.

Is it happening for every theme in your case?

Cszyn commented 3 months ago

No, One UI version 3.1

Wait, I did have the right idea. Turn off Material You and switch to Dynamic the issue shoud go away

Cszyn commented 3 months ago

I'll fire up an emulator and see, but it does not occur in Xiaomi HyperOS

I'll take that comment back. It still occurs on my Xiaomi 14 and MuMu emulator running android 14 and 12 respectably.

It happens only when you select 'material you' as theme.

Is it happening for every theme in your case?

No. just Material You.

aneesh1122 commented 3 months ago

Duplicate of #1699, as that seems to have gotten no attention.

Steps to reproduce the bug

  1. Have dark mode enabled (not pitch black!)
  2. Go to settings
  3. Change, for example, navigation bar position
  4. Theme changes to pitch black

Expected behavior

The setting should change without changing the theme

Actual behavior

The theme changes

Screenshots/Screen recordings

https://github.com/fast4x/RiMusic/assets/90613992/4c752971-7e42-4e5d-9142-108fc4820d7c

Logs

No response

RiMusic version

0.6.32

Android version

Android 11

Additional information

I think this happens with many more settings, not just the ones I showcased

Add 'Material You' in your title

Cszyn commented 3 months ago

(in my opinion) It's probably a minor oversight and set to default to OLED black instead of the regular one.

privacyfreak84 commented 3 months ago

Turn off Material You and switch to Dynamic the issue shoud go away

What if I want to use material you?

Cszyn commented 3 months ago

Turn off Material You and switch to Dynamic the issue shoud go away

What if I want to use material you?

Wait a bit for Fast to notice. he do be coding ✍️✍️🔥🔥🔥

privacyfreak84 commented 3 months ago

Hope he notices this time; last time, the issue went overlooked and was buried under hundreds of other issues

privacyfreak84 commented 3 months ago

I do hope he notices soon

privacyfreak84 commented 3 months ago

...

privacyfreak84 commented 2 months ago

Wait a bit for Fast to notice

So much for that 😕

kzhe2059 commented 1 month ago

This has happened to me even when not changing settings, just opening the app after a bit of not using it.

privacyfreak84 commented 1 month ago

😢