search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.52k stars 130 forks source link

F-Droid build not reproducible #2179

Closed linsui closed 2 months ago

linsui commented 5 months ago

Steps to reproduce the bug

Your apk is built before you commit the last changes. This causes a small difference. See https://f-droid.org/en/docs/Reproducible_Builds/#vcs-info.

Expected behavior

Reproducible

Actual behavior

Not reproducible

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.37

Android version

12

Additional information

No response

fast4x commented 5 months ago

Hi thanks for reporting error, version/tag 0.6.37 should be ok while the one with the version/tag problem was 0.6.36.1

linsui commented 5 months ago

Your apk is built from 8730755c0825a7af22d3b83e135cada83df3eea3. https://monitor.f-droid.org/builds/log/it.fast4x.rimusic/36#site-footer I guess you built the apk first then committed the change.

fast4x commented 5 months ago

I’ll pay more attention to that, thank you.

linsui commented 5 months ago

So we skip 0.6.37? Or you rebuild the apk against the tag?

fast4x commented 5 months ago

Yes skip because I can’t build from the specific commit.

linsui commented 5 months ago

:ok_hand:

licaon-kter commented 3 months ago

reopen, you've tagged https://github.com/fast4x/RiMusic/releases/tag/v0.6.45.1 to f55affa8ac651175a1f426be2ab58861219e2658

but the APK was built from the older a553714caaff9e746e3fa58b29af5bf18c3ebeab ?

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7445634123#L1483

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/06cf7a95cc9a3e8ecd4163508f6965afe35848c4

fast4x commented 3 months ago

I have committed all code for resolving crash on 0.6.45 and builded with new tag 0.6.45.1

licaon-kter commented 3 months ago

@fast4x are we lost in translation? :)

fast4x commented 3 months ago

:) I added commits to created a new tag, that’s all I did.

licaon-kter commented 3 months ago

Great... ok... and you did not build the APK from the Tag commit

why? that's up to you :)

what now? please build a NEW APK from the Tagged commit, or delete the Tag and re-Tag to the NEW commit

fast4x commented 3 months ago

Friday I’ll do the new version, skip this version

linsui commented 3 months ago

0.6.46 build also failed. Which commit does it build from?

fast4x commented 3 months ago

Hi, commit is https://github.com/fast4x/RiMusic/commit/f55affa8ac651175a1f426be2ab58861219e2658

There are new things,

Maybe that’s why you’re here?

linsui commented 3 months ago

https://gitlab.com/linsui/fdroiddata/-/commit/740797646364550b1da1f9bdef972a69ad739905 Can you move the tag to that commit then rebuild the apk from the tag?

fast4x commented 3 months ago

Unfortunately can't reuse existing tag with other commit. I can create a new one and rebuild apk. Would be ok?

linsui commented 3 months ago

Please rebuild the apk from a commit. And please make sure it maych the tag next time. Maybe you can disable vcsInfo. :)

fast4x commented 3 months ago

App rebuilded at specific commit (34689e1768679ecd590c437c012d7ccae303293d) and added apk in existing tag 0.6.46 I've understand what was my error...

linsui commented 3 months ago

The apk is not reproducible. it.fast4x.rimusic_47.apk.zip

can you clean the cache and rebuild the apk?

fast4x commented 3 months ago

Yes i do

fast4x commented 3 months ago

Done and uploaded new apk

linsui commented 3 months ago

It's still not reproducible. I have no idea...

fast4x commented 3 months ago

Then the problem is not that, i can create a new tag but i don't know other.

linsui commented 3 months ago

Is jdk changed?

fast4x commented 3 months ago

No, it's same as before

fast4x commented 3 months ago

@licaon-kter @linsui Maybe it fails because the gradle file contains two flavors? Can you configure the build to compile the flavour foss?

Flavour foss is default for F-Droid

licaon-kter commented 3 months ago

Can you configure the build to compile the flavour foss?

will try, brb

licaon-kter commented 3 months ago

trying foss for https://github.com/fast4x/RiMusic/releases/tag/v0.6.46

==== detail begin ====
verification of APK with copied signature failed
Comparing reference APK to APK with copied signature...
Unexpected diff output:
diff -r /tmp/tmpqwr020mc/unsigned_binaries_it.fast4x.rimusic_47.binary/content/META-INF/version-control-info.textproto /tmp/tmpqwr020mc/_tmp_tmpqwr020mc_sigcp_it.fast4x.rimusic_47/content/META-INF/version-control-info.textproto
4c4
<   revision: "34689e1768679ecd590c437c012d7ccae303293d"
---
>   revision: "a68b94aa6aebaf279daa02b2d634f7b3b70bf006"
Binary files /tmp/tmpqwr020mc/unsigned_binaries_it.fast4x.rimusic_47.binary/content/assets/dexopt/baseline.prof and /tmp/tmpqwr020mc/_tmp_tmpqwr020mc_sigcp_it.fast4x.rimusic_47/content/assets/dexopt/baseline.prof differ
Binary files /tmp/tmpqwr020mc/unsigned_binaries_it.fast4x.rimusic_47.binary/content/assets/dexopt/baseline.profm and /tmp/tmpqwr020mc/_tmp_tmpqwr020mc_sigcp_it.fast4x.rimusic_47/content/assets/dexopt/baseline.profm differ
Binary files /tmp/tmpqwr020mc/unsigned_binaries_it.fast4x.rimusic_47.binary/content/classes.dex and /tmp/tmpqwr020mc/_tmp_tmpqwr020mc_sigcp_it.fast4x.rimusic_47/content/classes.dex differ
==== detail end ====
fast4x commented 3 months ago

On next Friday I'll build new tag, so we can try again.

Thanks

fast4x commented 3 months ago

New tag builded, flavour foss

linsui commented 3 months ago

Still not reproducible... Let's check it again:

Is the apk built with jdk 17 from https://github.com/fast4x/RiMusic/releases/tag/v0.6.47? Did you clean the cache before the build? Did you run any other commands before gradle assembleFossRelease?

fast4x commented 3 months ago

Yes, jdk 17, I'll clean cache and run command for rebuild apk.

fast4x commented 3 months ago

before the command assemble.... I did not execute anything

fast4x commented 3 months ago

The only difference from the last build played by F-Droid is the introduction of flavour foss and accrescent.

linsui commented 3 months ago

Which OS do you use?

fast4x commented 3 months ago

Today re build with new tag for fix any bugs.

fast4x commented 3 months ago

Which OS do you use?

Windows 11 with Android Studio

linsui commented 3 months ago

Can you also try rebuilding the apk out of AS?

fast4x commented 3 months ago

From the command line?

linsui commented 3 months ago

Yes

fast4x commented 3 months ago

If you agree I would test with the two apk files, could be he FDroid is compiling the flavor accrescent and finding the apk file foss, find it different?

fast4x commented 3 months ago

I think isn't reproducible because it build accrescent and not foss...

fast4x commented 3 months ago

Yes

yes I'll build from command line

linsui commented 3 months ago

https://gitlab.com/linsui/fdroiddata/-/jobs/7550604124#L427 We build the foss flavor.

fast4x commented 3 months ago

https://gitlab.com/linsui/fdroiddata/-/jobs/7550604124#L427 We build the foss flavor.

Would be the gradle version? I see that fdroid use 8.6 I'll check it in my project.

linsui commented 3 months ago

It's from https://github.com/fast4x/RiMusic/blob/master/gradle/wrapper/gradle-wrapper.properties.

fast4x commented 3 months ago

I'm confused, i don't understand why not build.

linsui commented 3 months ago

I don't know, either... Maybe you can try rebuild 0.6.44 and check if the apk is changed.

fast4x commented 3 months ago

Builded new tag v0.6.47.1 with vcsInfo disabled

linsui commented 3 months ago

It's reproducible finally! What's changed?