Lyrics is limited to thumbnail size - Githubissues

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.

https://rimusic.xyz

GNU General Public License v3.0

2.21k stars 113 forks source link

Lyrics is limited to thumbnail size #2451

Closed aneesh1122 closed 3 months ago

aneesh1122 commented 3 months ago

Steps to reproduce the bug

https://github.com/fast4x/RiMusic/assets/45353488/b1e50dd0-3c0d-43b3-a804-d3d04381769d

Expected behavior

The lyrics should take all the available area

Actual behavior

The lyrics are limited to thumbnail size.

The lyrics are expanded to the available area after the song is changed.

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.40.1

Android version

Android 13 HyperOS

Additional information

No response

ALMIGHTY-VC commented 3 months ago

How are u getting such hazy lyrics it seems good i want it too bro care to teach me?

aneesh1122 commented 3 months ago

How are u getting such hazy lyrics it seems good i want it too bro care to teach me?

You mean that glowing lyrics? I implemented it myself and did a pull request. It will be available to you all after fast4x merges my pull request.

If you're asking about removing album cover for lyrics, do this Screenshot_2024-06-24-20-56-09-820_it.fast4x.rimusic.debug-edit.jpg

ALMIGHTY-VC commented 3 months ago

Oh thanks bro u have implemented very creative ideas in this version too 🙌👌

aneesh1122 commented 3 months ago

Oh thanks bro u have implemented very creative ideas in this version too 🙌👌

Thanks bro. Many more to come

NikunjKhangwal commented 3 months ago

Just out of curiosity since you already know programming, can't you fix it yourself? 🤔

aneesh1122 commented 3 months ago

Just out of curiosity since you already know programming, can't you fix it yourself? 🤔

I tried but I couldn't. It's funny that I'm reporting a bug about something I've implemented myself but there are things only fast4x can do 😅

NikunjKhangwal commented 3 months ago

I tried but I couldn't. It's funny that I'm reporting a bug about something I've implemented myself but there are things only fast4x can do 😅

Ah! Beginners struggle. Fair enough

aneesh1122 commented 3 months ago

I tried but I couldn't. It's funny that I'm reporting a bug about something I've implemented myself but there are things only fast4x can do 😅

Ah! Beginners struggle. Fair enough

https://github.com/fast4x/RiMusic/assets/45353488/6869eb3a-d0f5-4402-b81a-b2fd5425abd3

https://github.com/fast4x/RiMusic/assets/45353488/181ada0c-8922-45b8-9363-a0ce2e8bebdf

Bwahahahahaha

NikunjKhangwal commented 3 months ago

Now we're talking 👌🏼

aneesh1122 commented 3 months ago

Now we're talking 👌🏼

I'm thinking of making this the default option otherwise people won't even know about the new changes. Many are still using lyrics over thumbnail and are surprised when I tell them they can do this too.

fast4x commented 3 months ago

Available from version 0.6.41

NikunjKhangwal commented 3 months ago

I'm thinking of making this the default option otherwise people won't even know about the new changes. Many are still using lyrics over thumbnail and are surprised when I tell them they can do this too.

Would be nice. I like it too as it's a good middle ground between fullscreen and thumbnail lyrics. Also it kinda solved two old requests i had which is having gradient behind lyrics and having timeline in fullscreen lyrics. I have minor problem tho. As i'm using button background, it's too close to the next songs strip. Can you increase the spacing?

photo_2024-06-26_16-52-12

aneesh1122 commented 3 months ago

I'm thinking of making this the default option otherwise people won't even know about the new changes. Many are still using lyrics over thumbnail and are surprised when I tell them they can do this too.

Would be nice. I like it too as it's a good middle ground between fullscreen and thumbnail lyrics. Also it kinda solved two old requests i had which is having gradient behind lyrics and having timeline in fullscreen lyrics. I have minor problem tho. As i'm using button background, it's too close to the next songs strip. Can you increase the spacing?

There's a space when someone activates either the transparent action bar or modern controls because there were cases of overlapping or clipping.

In your case there is no overlapping and I have to give as much area as possible for the expanded player.

NikunjKhangwal commented 3 months ago

There's a space when someone activates either the transparent action bar or modern controls because there were cases of overlapping or clipping.

In your case there is no overlapping and I have to give as much area as possible for the expanded player.

Ok, Fair enough