search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
1.91k stars 100 forks source link

[Feature]: Adding an outline for buttons in the player #2502

Closed KOLIWAN closed 2 months ago

KOLIWAN commented 2 months ago

Description

In some circumstances, such as shown in the screenshot, it's hard to see the player control buttons because they blend into the background.

Screenshot_20240627_135210

Suggested Solution

I suggest adding the ability to enable an outline for player control buttons for better visibility, as @aneesh1122 has already done for song lyrics.

Alternatives

No response

Additional Context

No response

aneesh1122 commented 2 months ago

What theme are you using?

Why do you have that background behind the lyrics? Shouldn't it be clean?

Why don't you disable transparent action bar? It will solve those visibility issues

KOLIWAN commented 2 months ago

What theme are you using?

Why do you have that background behind the lyrics? Shouldn't it be clean?

Why don't you disable transparent action bar? It will solve those visibility issues

I use dynamic theme, background shouldn't be clean because when you disable Show thumbnail option, lyrics shown like at the screenshot. Actually I've copied your settings preset as you've shown here https://github.com/fast4x/RiMusic/issues/2461#issuecomment-2187112002 :)

Definitely disable transparent action bar solves the issue, but anyway transparent action bar looks much nicer

aneesh1122 commented 2 months ago

because when you disable Show thumbnail option, lyrics shown like at the screenshot.

It should be clean. So, dark mode or light mode?

Also send the song's link.

What player background are you using? I want to recreate your situation and see why you have that lyrics background.

KOLIWAN commented 2 months ago

because when you disable Show thumbnail option, lyrics shown like at the screenshot.

It should be clean. So, dark mode or light mode?

Also send the song's link.

What player background are you using? I want to recreate your situation and see why you have that lyrics background.

Dark mode Background colors -> blurred song cover https://music.youtube.com/watch?v=Msqg2BPTlMI

aneesh1122 commented 2 months ago

Dude, you're using 'Background progress bar' for the Player. Should have told me that before.

Anyways, I added an option to enable black gradient to improve visibility. Try that out when the next update is out.

KOLIWAN commented 2 months ago

Dude, you're using 'Background progress bar' for the Player. Should have told me that before.

Anyways, I added an option to enable black gradient to improve visibility. Try that out when the next update is out.

Thanks man, sorry for that, i totally forgot about background progress bar, I didn't even noticed it

KOLIWAN commented 2 months ago

Dude, you're using 'Background progress bar' for the Player. Should have told me that before.

Anyways, I added an option to enable black gradient to improve visibility. Try that out when the next update is out.

Gradient at the bottom solves this issue and looks nice, thanks you man

aneesh1122 commented 2 months ago

@fast4x close this issue as completed