fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.11k stars 109 forks source link

When song lyrics are turned on, the visualizer disappears #2527

Closed KOLIWAN closed 3 months ago

KOLIWAN commented 3 months ago

Steps to reproduce the bug

  1. Play the song
  2. Turn on visualizer
  3. Open lyrics
  4. Close lyrics
  5. Visualizer disappeared, need to turn it on manually

https://github.com/fast4x/RiMusic/assets/76595855/c7e7e3c9-3509-4d41-acc0-f62a313b010a

Expected behavior

If the visualizer was previously enabled, it should reappear after closing the song lyrics

Actual behavior

After closing the song lyrics, the previously enabled visualizer disappears, you need to re-enable it

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.41

Android version

Android 13

Additional information

This bug is especially annoying because the buttons to switch visualizer modes are on top of thumbnail, and it's very easy to miss a button, the song lyrics will turn on, and after exiting the song lyrics the visualization disappears and has to be turned on again :(

fast4x commented 3 months ago

It’s not a bug, how do you read lyrics in the middle of the moving chart?

KOLIWAN commented 3 months ago

It’s not a bug, how do you read lyrics in the middle of the moving chart?

No, I mean when you close the lyrics, if there was turned on visualizer before, it has to be shown

fast4x commented 3 months ago

Ah ok it's feature...

fast4x commented 3 months ago

Actually, if you turn on lyrics, the visualizer is disabled and vice versa, then it has to be reactivated manually.