fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.36k stars 123 forks source link

Bottom gradient does not work in landscape mode #2529

Closed KOLIWAN closed 3 months ago

KOLIWAN commented 4 months ago

Steps to reproduce the bug

  1. Turn on bottom gradient
  2. Play song
  3. Enter landscape mode

https://github.com/fast4x/RiMusic/assets/76595855/7bd7a9e5-d436-4460-8c7d-57f6c3c599f1

Expected behavior

Expected to see bottom gradient both in portrait and landscape modes if enabled

Actual behavior

Bottom gradient doesn't work in landscape mode

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.41

Android version

Android 13

Additional information

I suppose this bug could affect Android Auto users as normally they use app in landscape mode

aneesh1122 commented 4 months ago

In landscape mode the gradient is from the top since that's where the title and artist's name are present.

kris20030705 commented 4 months ago

Not working in material theme too(dark mode).

In landscape mode the gradient is from the top since that's where the title and artist's name are present.

aneesh1122 commented 4 months ago

Not working in material theme too(dark mode).

In landscape mode the gradient is from the top since that's where the title and artist's name are present.

It's working.

aneesh1122 commented 3 months ago

I've removed the gradient and added a constant shade of black/white according to the theme.

https://github.com/fast4x/RiMusic/pull/2537#issuecomment-2198253618

kris20030705 commented 3 months ago

I've removed the gradient and added a constant shade of black/white according to the theme.

#2537 (comment)

Why gradient theme is the only theme that is awesome..! Other looks unfinished..!

aneesh1122 commented 3 months ago

I've removed the gradient and added a constant shade of black/white according to the theme.

#2537 (comment)

Why gradient theme is the only theme that is awesome..! Other looks unfinished..!

This black shade/gradient works only if you're using blurred cover background.

It won't even get the option if you're using any other backgrounds.