search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.11k stars 108 forks source link

Improve Player's Icon and song visibility #2554

Open faustaahmad opened 3 months ago

faustaahmad commented 3 months ago

Description

Lacking visibility: ・Youtube/Music Icon ・Song & Artist title ・Top Header icons (arrow down, RiMusic, three dots)

Blur with Thumbnail Blur no Thumbnail Fluid with Thumbnail

Suggested Solution

Youtube/Music icon, Song & Artist title, Top Header icons should be colored with same style as "People" or Artist icon similar to "Blur no Thumbnail" Song & Artist title

Alternatives

Follow heart/favorite icon style of color

Additional Context

No response

faustaahmad commented 3 months ago

Top Header Icons doesnt seem to be lacking visibility until they met with similar color pallete as the background, but they are prune to lack of visibilty

faustaahmad commented 3 months ago

Also enable "Show Bottom Gradient" by default when blurred background active Slightly darker background but better visibility

ON OFF
aneesh1122 commented 3 months ago

The visibility is better with 'No Thumbnail' because I made it that way. I did not change it for other modes because some people don't like changes and it's not easy to give choices for every single thing and I didn't want to change something important casually so I changed things for the mode I created. 'No Thumbnail' mode is my 'Lab' where I experiment things without any restrictions.

Also enable "Show Bottom Gradient" by default

Can't do that. As I said above, Some people don't like changes so I can't make it default.

faustaahmad commented 2 months ago

@aneesh1122 I just realized that it seems like this behaviour only happens in Youtube Video or Local songs (see icons and title colour above) Youtube Music always white & visible

aneesh1122 commented 2 months ago

@aneesh1122 I just realized that it seems like this behaviour only happens in Youtube Video or Local songs (see icons and title colour above) Youtube Music always white & visible

That's because song's name is linked to album and artist's name is linked to artist's page.

If you can't read it properly it means you can't open album or artist page

faustaahmad commented 2 months ago

Sorry, but i dont know those color are intended for that purpose in the first place The app can still open their youtube page as artist, no reason to make it less visible

Isnt it better to have popup message when the songs got no album/artist linked rather than making the title less visible