search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.44k stars 128 forks source link

Great Update! Thankyou so much ❤️ Some More Bug Fixes in player screen #2644

Open Vishcot opened 4 months ago

Vishcot commented 4 months ago

Description

i would like to bring out some more here and there tweaks in this request.. Screenshot_20240706-112818

Suggested Solution

Colour Blue: Please vertically align the thumbnail and timeline sizes precisely. and also in some "upnext songs" which has alot of artists mentioned, exceeds the blue line border.. Screenshot_20240706-115342.png

Colour Yellow: Increase the margin between the artist's name and the timeline bar to improve spacing on all forms by pushing names and artists a bit above and equally giving margins overall in "control style" and same with menu button and upnext ( a bit bit margin is required overall )

Colour Green: Placing only 5 thumbnail icons without label as "Up Next" aligned to purple line as horizontally drawn would enhance the design. Implement a "click to play" behavior for the up next songs, instead of automatically adding them to the queue when clicked.

Colour Red: Considering the square screen ratio, remove the rounded corners to ensure a more comfortable viewing experience for all users.

Alternatives

No response

Additional Context

No response

aneesh1122 commented 4 months ago

Please vertically align the thumbnail and timeline sizes precisely

I've added separate size options for both thumbnail and timeline. Adjust the settings accordingly.

also in some "upnext songs" which has alot of artists mentioned, exceeds the blue line border

Can't put blank space there. It is necessary to get as much information as possible about the next songs. adding space means less space for details to be shown. Not sure about aesthetic but it's for sure practical.

Increase the margin between the artist's name and the timeline bar to improve spacing on all forms by pushing names and artists a bit above and equally giving margins overall in "control style" and same with menu button and upnext ( a bit bit margin is required overall )

It looks like you're using expanded player. Enable the 'expanded player' toggle inside appearance settings, disable the expanded player and you'll have the player with proper spacing

Placing the "Up Next" text between two suggestions on the purple bar would enhance the design.

"Up Next" will be removed in the next update.

ALMIGHTY-VC commented 3 months ago

The thumbnail size of my app also don't change i have to use the expanded player option to change at the end

https://github.com/user-attachments/assets/6ea9d9c5-8de2-4df1-8ed7-53a0bf287948

aneesh1122 commented 3 months ago

The thumbnail size of my app also don't change i have to use the expanded player option to change at the end

The size of buttons, texts and other things doesn't depend upon your device resolution. It has a fixed value. In your device thumbnail doesn't have enough room to expand that's why it's not changing.

Try changing buttons to disabled and timeline to thin bar. You'll see the size changing

ALMIGHTY-VC commented 3 months ago

The thumbnail size of my app also don't change i have to use the expanded player option to change at the end

The size of buttons, texts and other things doesn't depend upon your device resolution. It has a fixed value. In your device thumbnail doesn't have enough room to expand that's why it's not changing.

Try changing buttons to disabled and timeline to thin bar. You'll see the size changing Oh okay will try it send the response here

ALMIGHTY-VC commented 3 months ago

So i shifted to rimsuic ui changed the thumbnail size to biggest yup it did not implement and when i toggled exoanded view button it got the biggest size and when i choose expanded it even touched my borders so i think the way for me to implement it is too choose the thumbnail size and use expanded view button

aneesh1122 commented 3 months ago

So i shifted to rimsuic ui changed the thumbnail size to biggest yup it did not implement and when i toggled exoanded view button it got the biggest size and when i choose expanded it even touched my borders so i think the way for me to implement it is too choose the thumbnail size and use expanded view button

Timeline -> Thin bar Play button -> Disabled

ALMIGHTY-VC commented 3 months ago

So i shifted to rimsuic ui changed the thumbnail size to biggest yup it did not implement and when i toggled exoanded view button it got the biggest size and when i choose expanded it even touched my borders so i think the way for me to implement it is too choose the thumbnail size and use expanded view button

Timeline -> Thin bar Play button -> Disabled

https://github.com/user-attachments/assets/d0c5fd26-5026-45bd-9cc2-ab62e8c3c824

But it does make a difference in expanded view mode