search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.6k stars 132 forks source link

Shuffle button seems to be allways activate on the player (autoshuffle in player) #3023

Closed frenchy82 closed 3 days ago

frenchy82 commented 3 months ago

Steps to reproduce the bug

Choose a music, goto the player On the player the shuffle button is lit whether you are using it or not.

Expected behavior

If you have not selected random music, the shuffle button shoud be gray as the others buttons

Actual behavior

Same as description

Screenshots/Screen recordings

No response

Logs

No response

RiMusic version

0.6.45.1

Android version

Android 12

Additional information

No response

aneesh1122 commented 3 months ago

Shuffle is not a toggle. It is a button which activates every time you choose it.

frenchy82 commented 3 months ago

Sorry, but in English it's not so easy for me :) But it's just a problem of appearance. Whether you activate or not the random, the button keeps the same appearance, the same color, so we can't know if it's activated or not.

If we take the loop button for example, there is no this visual problem

aneesh1122 commented 3 months ago

Sorry, but in English it's not so easy for me :) But it's just a problem of appearance. Whether you activate or not the random, the button keeps the same appearance, the same color, so we can't know if it's activated or not.

If we take the loop button for example, there is no this visual problem

You can't activate the shuffle. You can just use it as many times as you want to rearrange songs.

For example, let's say a machine has 5 balls of different colors and there's a 'shuffle' button on it. Every time you press the 'shuffle' button the balls will be rearranged. The balls won't be continuously shuffled. It's a button which does things one time.

frenchy82 commented 3 months ago

OK, i do understand. thanks for this explanation

fast4x commented 3 months ago

In fact, there is an autoshuffle function but the player does not have it. It’s present in the player in the notification area. In that case it can be activated or deactivated. I implement it!

aneesh1122 commented 3 months ago

In fact, there is an autoshuffle function but the player does not have it. It’s present in the player in the notification area. In that case it can be activated or deactivated. I implement it!

What does autoshuffle exactly do?

fast4x commented 3 months ago

When enabled, shuffle next song...

aneesh1122 commented 3 months ago

When enabled, shuffle next song...

So everytime song changes it will shuffle the songs next in queue?

fast4x commented 3 months ago

yes