search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.4k stars 123 forks source link

Cover images are not shown for downloaded songs #3232

Open itxnotsaqlain opened 2 months ago

itxnotsaqlain commented 2 months ago

Steps to reproduce the bug

  1. Directly download any song without playing it
  2. Go offline, turn off Wifi or Mobile data before playing
  3. Now play the song
  4. Album or song cover is not shown

Expected behavior

  1. Album or song covers should be shown for the downloaded songs at all places like in playlists, now playing screen, on queue, mini queue, popup menu and mini player while being offline.
  2. There should be only one image download for the cover of a song and it should be resized to fit at every place.

Actual behavior

  1. Instead covers are only shown in playlists and mini player but not at now playing screen, popup menu and mini queue.
  2. Instead it downloads, one image to be shown at playlists and queues, one for the now playing screen, one for popup menu and one for the mini queue.

Screenshots/Screen recordings

https://github.com/user-attachments/assets/e581d280-69d7-4a19-8fc3-d2b4fba0ea33

Logs

No response

RiMusic version

Latest v0.6.47.1

Android version

Android 13

Additional information

Covers do load to cache when you get online again but you have to play every song and open pop menu for each song in order to load the images to cache, which can be done for few songs but I have over 1200 songs to download and it will be time consuming, painful and frustrating. Also if for some reason you have to clear cache, all the data(Covers) will be lost and you have to do that painful process once again.

What can be done? Can you do something about it like instead of saving cover images into cache save them in separate folder and make it to download one cover for a song and resized it to be shown at every other place for that song.

itxnotsaqlain commented 2 months ago

Is there any fix for this issue?? #3232 @fast4x

fast4x commented 2 months ago

For now not

itxnotsaqlain commented 2 months ago

For now not

Well hope so in future there'll be some. Also after updating to the latest version, the app keep on crashing multiple times in middle of songs while this wasn't the case with previous version. Please do something about it...