fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.49k stars 129 forks source link

Player crash with EOF #4465

Open twistios opened 2 days ago

twistios commented 2 days ago

Version of RiMusic

0.6.59

Android version

14

Tell us how you trigger this bug

  1. Open RiMusic
  2. Start a specific song (https://m.youtube.com/watch?v=IdlQ-rDuK_w)
  3. Go back to list of songs
  4. Scroll down list of songs.

What was your expectation?

The player should not stop/crash.

What more can you tell us? (Optional)

I think that the error could be related to that song but I am not sure. The song played for some time, maybe a minute, then the player crashed (not the app). I am not logged in so it rather not is the login error. The song is fully cashed. The crash happens reproducible at 1:02, so it seems like a cache error.

Logs (Optional)

2024-11-11 16:46:53:443 ERROR: PlayerServiceModern - PlayerService onPlayerError T2.m: Source error
    at T2.Q.j(SourceFile:17)
    at T2.Q.handleMessage(SourceFile:386)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loopOnce(Looper.java:230)
    at android.os.Looper.loop(Looper.java:319)
    at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: java.io.EOFException
    at n3.l.j(SourceFile:25)
    at n3.l.l(SourceFile:29)
    at F3.d.g(SourceFile:4565)
    at f3.M.c(SourceFile:242)
    at j3.i.run(SourceFile:37)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)
twistios commented 2 days ago
Details

https://github.com/user-attachments/assets/e2f82598-c4f0-4482-ae04-74d2ca148742

twistios commented 2 days ago

I know that probably this can be solved via deleting the cache for that song but still the underlying issue should be investigated.

twistios commented 2 days ago

The error is not related to scrolling the songs list as it can be seen from the video also.

fast4x commented 1 day ago

Interesting

knighthat commented 1 day ago

I think it's related #4421 #4420 which were fixed in #4425, can you compile latest code to test it?

twistios commented 1 day ago

The cached version has Itag 140. It was cached before the YTM login problems. Using latest code to test it is hard, as I don't know how the cache gets corrupted. So I don't know how I can know it got fixed.

twistios commented 1 day ago

I now think that the log is unrelated to the crash. So these seem to be two different problems. I have this suspicion because I got basicly the same crash with another song without any (useful) log output.

video 1

https://github.com/user-attachments/assets/b465b11e-8490-4f23-bc6d-ec9cfb1881a5

video 2

https://github.com/user-attachments/assets/c4485c0d-5772-4f60-87d8-c5d26bd8fd28

As it can be seen from the second video, it starts the second song after it fails. For the first song ("not fair") instead it restarted the playlist with the first song of the "all" category.

So maybe these problems are actually different problems and the log was related to the first problem.

twistios commented 1 day ago

I just noticed that both crash at 1:02 it seems. Pretty weird.

CollegeTimeOhNo commented 18 hours ago

Having the exact same issue with a few different songs since getting the new update. It doesn't give any kind of information as to why, the player just disappears at a specific point for a few songs/after a random amount of songs it just ends with this update.

fast4x commented 9 hours ago

Wait for new release, try also update the song.