Migration to translator 1.1.1

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.

https://rimusic.xyz

GNU General Public License v3.0

2.56k stars 131 forks source link

Migration to translator 1.1.1 #4513

Closed twistios closed 1 week ago

twistios commented 1 week ago

updating to translator version 1.1.1
updating ktor to 3.0.1 (requirement of translator)
- migration of code to use ktor 3.0.1

The improvement of the romanization code is currently todo (the reason why I want to update translator in the first place).

twistios commented 1 week ago

Improvements are mostly done now. See commits and commit-messages for details. Or I can explain if requested.

twistios commented 1 week ago

Next idea is to add a selection menu for the 4 diffent options (will do another pull request):

off
source
target
both

Or a second toggle instead of the menu.

twistios commented 1 week ago

Still needs a bit of work. Currently it is not visible if the option is enabled or not. EDIT: Ok, it is visible.

twistios commented 1 week ago

Demo 1

![demo 1](https://github.com/user-attachments/assets/6e76783b-6ead-43e3-8d7f-48a977dc469f)

Demo 2

![demo 2](https://github.com/user-attachments/assets/2bcfe4a2-0cc5-4df6-bd23-c012c6ca2995)

Settings options

![settings options](https://github.com/user-attachments/assets/ad930797-c57f-4f7a-9887-70bb520b3990)

fast4x commented 1 week ago

What's the difference with actual?

aneesh1122 commented 1 week ago

What's the difference with actual?

The previous translator version doesn't support romanization of the original lyrics.

BTW I've done all these and added some more things. I'll do a pull request in a few minutes. Please reject this pull request and accept mine.

twistios commented 1 week ago

What's the difference with actual?

Also there were different problems with traditional Chinese that are solved now.

Anyway, I will close this full request as the pull-request by @aneesh1122 contains these changes including the new improved options for romanization (including more consistency of applying it).