search

fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.56k stars 131 forks source link

Piped Instance selection does not want to close #4514

Closed twistios closed 1 week ago

twistios commented 1 week ago

Version of RiMusic

0.6.59 (commit 6b824a55)

Android version

14

Tell us how you trigger this bug

  1. Clean install of RiMusic
  2. Open Settings > Misc
  3. Activate "Enable piped synchronization"
  4. Select button "Change Instance"
  5. In the menu, select "kavin.rocks libre" (tested instance, any instance should probably work) and then menu closes
  6. Switch to Data-Settings
  7. Return to Misc-Settings

What was your expectation?

The instance selection "drop down" should not open again.

What more can you tell us? (Optional)

The "drop down" for selection of an instance reappears after returning from another settings page, even if piped was disabled in the meantime. The bug stops once the settings are exited. It returns in the same way when you click on the piped instance selection button again.

Abhinavreddy-B commented 1 week ago

is this solved?

if not, PR #4519 will do the job

twistios commented 1 week ago

I only opened the bug report, I was working on something else at that moment.

twistios commented 1 week ago

I think I can confirm the fix.