Closed Abhinavreddy-B closed 2 days ago
This PR solves the following issues:
There were 2 point of problems in previous code:
in MainActivity, the colorPalette of the whole app is being updated even if the theme was not dynamic. https://github.com/fast4x/RiMusic/blob/4567701c3e4669075a6cdf0f1a966f628cfd61a9/composeApp/src/androidMain/kotlin/it/fast4x/rimusic/MainActivity.kt#L566C1-L569C1
MainActivity
In Player, the bitmap from binder.bitmap is not the correct bitmap of the image, though I am not sure what bitmap it was returning, I am sure that it is not the correct one because the hsl of dominantSwatch is coming out to be null. https://github.com/fast4x/RiMusic/blob/4567701c3e4669075a6cdf0f1a966f628cfd61a9/composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/player/Player.kt#L735C1-L742C1
Player
hsl
dominantSwatch
Woooowwwww 😂
It works fine from my local machine, when I run through ADB. But when I generate an APK and test it, it doesn't work. can you please check if I am doing anything wrong here?
ok
This PR solves the following issues:
4540
4544
4554
4550
There were 2 point of problems in previous code:
in
MainActivity
, the colorPalette of the whole app is being updated even if the theme was not dynamic. https://github.com/fast4x/RiMusic/blob/4567701c3e4669075a6cdf0f1a966f628cfd61a9/composeApp/src/androidMain/kotlin/it/fast4x/rimusic/MainActivity.kt#L566C1-L569C1In
Player
, the bitmap from binder.bitmap is not the correct bitmap of the image, though I am not sure what bitmap it was returning, I am sure that it is not the correct one because thehsl
ofdominantSwatch
is coming out to be null. https://github.com/fast4x/RiMusic/blob/4567701c3e4669075a6cdf0f1a966f628cfd61a9/composeApp/src/androidMain/kotlin/it/fast4x/rimusic/ui/screens/player/Player.kt#L735C1-L742C1