fast4x / RiMusic

A multilingual Android application for streaming music from YouTube Music.
https://rimusic.xyz
GNU General Public License v3.0
2.55k stars 131 forks source link

[Feature]: Playlist Descriptions #4586

Open KyNarec opened 2 days ago

KyNarec commented 2 days ago

Started with implementing Playlist Descriptions (see https://github.com/fast4x/RiMusic/issues/4566).

TODO

Note

I would highly appreciate some help with developing this feature because I'm at my wit's end.

twistios commented 1 day ago

Maybe in composeApp/src/androidMain/kotlin/it/fast4x/rimusic/Database.kt, AutoMigration for 22 to 23 and 23 to 24 is missing (as there is for previous db version) but I have no idea how this works so just a comment.

fast4x commented 1 day ago

Not modification in database structure please

fast4x commented 1 day ago

Implement description only for online playlists...

KyNarec commented 1 day ago

Implement description only for online playlists...

So the descriptions should only be fetched from yt and should not be editable? What about piped sync?

fast4x commented 1 day ago

yep only yt, but what you mean for piped sync ?

KyNarec commented 1 day ago

yep only yt

👍

but what you mean for piped sync ?

While developing I looked at the renameDialoge in LocalPlaylistSongs.kt and in there it looked to me as if the playlist title was synced with piped. So correct me if I'm wrong (and I probably am) but if the title is synced, why should the description not be synced as well.

fast4x commented 1 day ago

Because description actually can be only in read-only mode, because it's not stored in db.