Closed kani-rifluxyss closed 8 years ago
:+1:
+1
+1 (This is the moment where you realize how much time Deliver gives us to do other important stuff! I have a deadline today for uploading new screenshots, so I just started the good 'ol Manual process instead...)
+1
+1
+1
+1
+1
:+1:
+1
+1
Thanks everyone of the +1
. I'm already working on a new version of deliver
using spaceship
.
Just a heads up: This is not a simple thing to change in deliver
, it required big refactors. I'm trying my best to finish the new version as soon as possible.
You can follow the progress here: https://github.com/KrauseFx/deliver/pull/259
I pushed a new version that shows a warning that deliver
doesn't work with the new iTunes Connect yet.
Is a "quick" fix on the current codebase feasible? Il 25/set/2015 20:03, "Felix Krause" notifications@github.com ha scritto:
I pushed a new version that shows a warning that deliver doesn't work with the new iTunes Connect yet.
— Reply to this email directly or view it on GitHub https://github.com/KrauseFx/deliver/issues/337#issuecomment-143308723.
Felix, just wanna to say thank you. I know it's a hard time now. Apple likes to make development harder ;) Keep calm and rock on warp-9 speed ;)
@pracucci Sorry, no. There have been major changes of how iTunes Connect works under the hood. I'm working on the new version as fast as I can :rocket:
Again, you can follow the progress over here https://github.com/KrauseFx/deliver/pull/259
@KrauseFx thanks for the update. We really appreciate your huge effort.
2015-09-26 0:22 GMT+02:00 Felix Krause notifications@github.com:
Again, you can follow the progress over here #259 https://github.com/KrauseFx/deliver/pull/259
— Reply to this email directly or view it on GitHub https://github.com/KrauseFx/deliver/issues/337#issuecomment-143366773.
A short update: https://github.com/KrauseFx/deliver/pull/259 is almost ready.
I'll upload a beta version later today once the pricing part is finished :+1:
I'm finally done, please check out the release notes https://github.com/KrauseFx/deliver/releases/tag/1.0.0.beta.
Please let me know if there is anything I forgot or anything that works differently than in previous versions.
Hi, I'm new to this environment, I installed deliver with "gem install" ... how can I install this beta ? Thanks
@cbo1964 Run sudo gem update deliver --pre
@KrauseFx - Thanks for the fast update! It is very much appreciated. One of the delightful features of creating the PDF, which you have to approve before it uploads is disabled ("In the beta version of Deliver the generation of the PDF is currently disabled").
I was very happy about that feature, so just had to mention that for your considerations :)
From release notes:
You can use the deliver --submit_for_review
Will this command just submit latest build for review or it will upload binatry, wait and submit it like previous versions of deliver? I think that the best way to update more than one app is:
I experience the issue posted below only sometimes when using the 'deliver' command. Not sure if it is related to the update, but that is at least what it feels like. Has anyone experienced same issue, and found a solution? I have succeeded in performing a 'deliver' occasionally, but not all the time.
[16:48:50]: Uploading './screenshots/zh-Hans/BoB_appStoreScreen_2_ipadRet_cmn-Hans.png'...
[16:48:57]: Uploading './screenshots/zh-Hans/BoB_appStoreScreen_2_iphone4_cmn-Hans.png'...
[16:49:00]: Uploading './screenshots/zh-Hans/BoB_appStoreScreen_2_iphone5_cmn-Hans.png'...
[16:49:14]: Uploading './screenshots/zh-Hans/BoB_appStoreScreen_2_iphone6_cmn-Hans.png'...
[16:49:19]: Uploading './screenshots/zh-Hans/BoB_appStoreScreen_2_iphone6plus_cmn-Hans.png'...
[16:49:25]: Uploading './screenshots/zh-Hant/BoB_appStoreScreen_2_ipadRet_cmn-Hant.png'...
[16:49:31]: Uploading './screenshots/zh-Hant/BoB_appStoreScreen_2_iphone4_cmn-Hant.png'...
[16:49:35]: Uploading './screenshots/zh-Hant/BoB_appStoreScreen_2_iphone5_cmn-Hant.png'...
[16:49:39]: Uploading './screenshots/zh-Hant/BoB_appStoreScreen_2_iphone6_cmn-Hant.png'...
[16:49:43]: Uploading './screenshots/zh-Hant/BoB_appStoreScreen_2_iphone6plus_cmn-Hant.png'...
[16:49:48]: Saving changes
/Library/Ruby/Gems/2.0.0/gems/spaceship-0.9.0/lib/spaceship/tunes/tunes_client.rb:147:in `handle_itc_response': Unauthorized access (Spaceship::TunesClient::ITunesConnectError)
from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.9.0/lib/spaceship/tunes/tunes_client.rb:271:in `update_app_version!'
from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.9.0/lib/spaceship/tunes/app_version.rb:229:in `save!'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/upload_screenshots.rb:43:in `upload'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/runner.rb:48:in `upload_metadata'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/runner.rb:18:in `run'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/commands_generator.rb:37:in `block (2 levels) in run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/commands_generator.rb:74:in `run'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/lib/deliver/commands_generator.rb:12:in `start'
from /Library/Ruby/Gems/2.0.0/gems/deliver-1.0.0.beta2/bin/deliver:5:in `<top (required)>'
from /usr/bin/deliver:23:in `load'
from /usr/bin/deliver:23:in `<main>'
One problem I found. The keywords field is wrong:
monitormonitoringservicecontrol
My keywords.txt
:
monitor
monitoring
service
control
@ricardopereira keywords are meant to be space separated, not new line:
monitor monitoring service control
Oh. Ok, thanks @bencollier.
Other issue I found is related with the app screenshots. I have two langs but on iTunes Connect they are mixed. E.g. first en
, second pt
, third en
, fourth pt
.
UPDATE: It's an iTunes Connect issue. :smile:
@KrauseFx does deliver beta version works with fastlane? I updated everything, installed deliver 1.0.0.beta but when I launch my lane, I get this crash
Jarvis:tmp_1443423504_93 alex $ fastlane deploy
[18:52:50]: Successfully loaded custom action '/mnt/cache/worker-store-ios-application-publish-1/tmp_1443423504_93/fastlane/actions/commit_apple_id.rb'.
[18:52:50]: -------------------------------------------------
[18:52:50]: --- Step: Verifying required fastlane version ---
[18:52:50]: -------------------------------------------------
[18:52:50]: fastlane version valid
[18:52:50]: ------------------------------
[18:52:50]: --- Step: default_platform ---
[18:52:50]: ------------------------------
[18:52:51]: Driving the lane 'ios deploy' 🚀
[18:52:51]: ---------------------
[18:52:51]: --- Step: deliver ---
[18:52:51]: ---------------------
[18:52:51]: -------------------
[18:52:51]: --- Step: slack ---
[18:52:51]: -------------------
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
[18:52:52]: Successfully sent Slack notification
[18:52:52]: Variable Dump:
[18:52:52]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios deploy"}
[18:52:52]: uninitialized constant Deliver::Deliverer
+------+-------------------------------------+-------------+
| fastlane summary |
+------+-------------------------------------+-------------+
| Step | Action | Time (in s) |
+------+-------------------------------------+-------------+
| 1 | Verifying required fastlane version | 0 |
| 2 | default_platform | 0 |
| 3 | deliver | 0 |
| 4 | slack | 1 |
+------+-------------------------------------+-------------+
[18:52:52]: fastlane finished with errors
/usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/actions/deliver.rb:21:in `block in run': uninitialized constant Deliver::Deliverer (NameError)
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/actions/deliver.rb:17:in `chdir'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/actions/deliver.rb:17:in `run'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:142:in `block (2 levels) in execute_action'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/actions/actions_helper.rb:37:in `execute_action'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:128:in `block in execute_action'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:127:in `chdir'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:127:in `execute_action'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/fast_file.rb:134:in `method_missing'
from (eval):55:in `block (3 levels) in parse'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/lane.rb:36:in `call'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/lane.rb:36:in `call'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:51:in `block in execute'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:46:in `chdir'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:46:in `execute'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/lane_manager.rb:43:in `cruise_lane'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/lib/fastlane/command_line_handler.rb:31:in `handle'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/bin/fastlane:36:in `block (2 levels) in run'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
from /usr/local/lib/ruby/gems/2.2.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/bin/fastlane:127:in `run'
from /usr/local/lib/ruby/gems/2.2.0/gems/fastlane-1.29.2/bin/fastlane:133:in `<top (required)>'
from /usr/local/bin/fastlane:23:in `load'
from /usr/local/bin/fastlane:23:in `<main>'
Do I also need to use a beta version of fastlane/core? Thanks
Edit: I checked fastlane code and the problem is inside fastlane deliver action.
@DeadCounter
I was very happy about that feature, so just had to mention that for your considerations :)
Don't worry, this feature will be available in the next beta version.
@iPavel92 Yes, deliver
will then upload metadata + binary and then submit the app for review, after the build was processed.
@DeadCounter The issue seems like you don't have write access to the application?
@dral3x Please read the release notes: The fastlane
action was not yet updated. Please use sh "deliver"
in your Fastfile
for now.
Thanks for the speedy update to deliver! Just two questions about the beta2 release:
1) automatic_release doesn't seem to be supported. Is that coming soon or am I missing something?
2) The categories appear to have changed. Where I used to put "Books" it now needs MZGenre.Books. Likewise, Health & Fitness is now MZGenre.Apps.Health_Fitness. Are these documented anywhere?
Thanks!
@mgamber
1) Check out the release notes https://github.com/KrauseFx/deliver/releases/tag/1.0.0.beta it's covered there 2) You can find the list of categories here
Got it. Many thanks!
I've replaced >deliver(skip_deploy: true, force: true)< with >sh "deliver"< in my fastfile any help what I'm doing wrong?
@artuan sh "deliver --force"
Still no success :/
/Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.18.0/lib/fastlane_core/itunes_connect/itunes_connect_helper.rb:79:in `wait_for_elements': Couldn't find element '.page-subnav' after waiting for quite some time (FastlaneCore::ItunesConnect::ItunesConnectGeneralError)
from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.18.0/lib/fastlane_core/itunes_connect/itunes_connect_helper.rb:20:in `open_app_page'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/itunes_connect/itunes_connect_new_version.rb:14:in `create_new_version!'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/app.rb:152:in `create_new_version!'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliver_process.rb:210:in `verify_app_on_itunesconnect'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliver_process.rb:38:in `run'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliverer.rb:135:in `finished_executing_deliver_file'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliverfile/deliverfile.rb:31:in `initialize'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliverer.rb:87:in `new'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/deliverer.rb:87:in `initialize'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:70:in `new'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:70:in `block in run_deliver'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:66:in `chdir'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:66:in `run_deliver'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:51:in `block (2 levels) in run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:152:in `run'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/lib/deliver/commands_generator.rb:14:in `start'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.13.5/bin/deliver:5:in `<top (required)>'
from /usr/bin/deliver:23:in `load'
from /usr/bin/deliver:23:in `<main>'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/fast_file.rb:167:in `block in sh'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/actions/actions_helper.rb:37:in `execute_action'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/fast_file.rb:166:in `sh'
from (eval):59:in `block (3 levels) in parse'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/lane.rb:36:in `call'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/lane.rb:36:in `call'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:51:in `block in execute'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:46:in `chdir'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/runner.rb:46:in `execute'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/lane_manager.rb:43:in `cruise_lane'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/lib/fastlane/command_line_handler.rb:31:in `handle'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/bin/fastlane:36:in `block (2 levels) in run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/bin/fastlane:127:in `run'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.29.2/bin/fastlane:133:in `<top (required)>'
from /usr/bin/fastlane:23:in `load'
from /usr/bin/fastlane:23:in `<main>'
@artuan Please try:
sudo gem uninstall deliver
Confirm all questions with y
sudo gem install deliver --pre
Add this to your Fastfile
sh "deliver --force"
Hey everyone, I've been working non-stop to get a new beta release out: deliver 1.0.0.beta3. Please let me know how that works for you.
Sorry that there is no fastlane
action for it yet, the reason for that is that it's not easily possible to have both (old and new) versions of deliver
in one fastlane
release.
Please do test the new beta release, as I want to get the first public 1.0 release out by tomorrow! (2015-09-29)
Send me feedback to how the new version is working. For those who don't know: 1.0 was rewritten from scratch.
Could not find option 'version' in the list of available options: username, app_identifier, app, ipa, metadata_path
Do I have to reinstall something else? Or init deliver once again?
@artuan I have the same issue as you, but I have succeeded in changing stuff on iTunes Connect without the version in my Deliverfile.. Not sure if it messes other stuff up though as I can't seem to get it to work properly at all times. Have you found a fix for it yet?
version
value is automatically taken from the ipa file directly. There is no need to provide this information manually
@DeadCounter not yet, actually this is the first app that I upload and it's quite a big challenge for me to get everything to work :/. + in the last month a lot of things changed (swift 2.0, itunesconnect... )
waiting for @KrauseFx (thank you for your support&work!)
P.S. in addition there is one other bug(xcode 7 related I suppose) when generating screenshots, the images are scrambled :/
@dral3x in my case I am not providing any ipa file. As of now, I merely upload new screenshots using Deliver, but just not providing the version works for now in my test environment on iTunes Connect, however, I wonder if it may cause troubles when I go to the live project with multiple versions available...
Got it. I don't know which version is taken then.
Me neither. It says nothing about it anywhere
In the latest release of the Beta it has a point stating: "Added automatic creation of new versions / modifying of existing versions"
Not sure if this is a good thing, how will I know which version I am targeting?
If a version is approved cannot be edited anymore, so I suppose it uses the first editable version
True - thanks for assisting thoughts on this matter :)
No problem. I'm working on updating my setup for auto publishing apps this morning. I'm facing all the new configuration changes and issues so it's worth sharing and helping, to let @KrauseFx working on the code :+1:
@dral3x so I have to comment out the this line ? -> version "1.0"
Deliver fails after iTunes connect updated yesterday (9/24)
We are using deliver for few months now, so far working good. Thanks for making this tool.
Yesterday Apple updated their UI for itunesconnect and deliver is failing.
Is there an update available to handle this?
Here is what it says: