search

fastred / IBAnalyzer

Find common xib and storyboard-related problems without running your app or writing unit tests.
http://holko.pl
MIT License
951 stars 26 forks source link

Support @IBAction in extension #9

Closed ethanhuang13 closed 7 years ago

ethanhuang13 commented 7 years ago

@IBAction func can be used in extension. I think IBAnalyzer should check if the missing implementation is in an extension.

fastred commented 7 years ago

This should work in simple cases like: https://github.com/fastred/IBAnalyzer/blob/master/IBAnalyzerTests/SwiftParserTests.swift#L53-L58. Would you be able to share your Swift code that IBAnalyzer fails on?

ethanhuang13 commented 7 years ago

My extension is in another file. Will it still pass?

fastred commented 7 years ago

Yeah, it should. Can you copy-paste the declaration of your method? (e.g. @IBAction func didTapButton(_ sender: UIButton) {)

elneruda commented 7 years ago

@ethanhuang13 this feature have been implemented, you can try it with the latest release ?

ethanhuang13 commented 7 years ago

Tested and it works! Thanks. However I have some other suggestion in output wording. Will open another issue.