fatiando / community

Community resources, guidelines, meeting notes, authorship policy, maintenance, etc.
Other
8 stars 4 forks source link

Update branch protection rules in our repos #117

Closed santisoler closed 1 year ago

santisoler commented 1 year ago

Description:

The main branch of most of our repos are protected against direct pushes by requiring that every push must be carried out through a PR. This enforces contributors, developers and maintainers to open a PR for every change, even if it's small. This ensures that the code in every commit in main is tested and passes all tests, documentation builds properly, and the change is explained and linked to a PR with a good narrative and discussion. It also prevents that contributors with writing privileges push changes to main by mistake (we've all been there).

But, recently GitHub changed the default behaviour of the branch protection rules, making admins able to bypass all of them, pushing directly to main included. So now, even if the condition to Require a pull request before merging is checked off, admins can push directly to main.

One way to solve this is to check off a new box called Do not allow bypassing the above settings, that won't allow admins to bypass these rules.

I'm attaching a screen capture of the branch protection rules in Harmonica, highlighting the box we need to check.

github

I think we need to apply these changes to all our repos, mainly to prevent ourselves pushing to main by mistake.

Apply to:

We want your help!

We know that maintenance tasks are very demanding, so we don't expect a single person to tackle this issue by themselves. Any help is very welcomed, so please comment below that you want to take care of the changes on any repository and we will assign it to you.

LL-Geo commented 1 year ago

Getting a boring meeting... So I clicked all the boxes🤣 Hope it solved the issue :)

santisoler commented 1 year ago

🤯 That's awesome @LL-Geo! I think we can close this then. Thank you very much!

leouieda commented 1 year ago

Love this! First seeing the issue and it's already closed 🙂 Thanks @LL-Geo

MGomezN commented 1 year ago

Great job @LL-Geo I was struggling with the difference between "check off" and "check" in the instructions: "One way to solve this is to check off" / " highlighting the box we need to check."

santisoler commented 1 year ago

I was struggling with the difference between "check off" and "check" in the instructions: "One way to solve this is to check off" / " highlighting the box we need to check."

I think I meant "check off" in the second sentence as well. Please, don't take my English as always right 🥲