Closed anarkiwi closed 4 years ago
Thanks Bob. How about 2 PRs, one that has only changes to agenttest.py and another that adds requirements.txt etc?
Re .gitignore - it's true, this does accumulate stuff over time - I guess as different people have different environments and different IDEs etc. I can optimize it for today for sure, but I don't know a way to ensure it stays small over time?
Regarding gitignore, you probably just want to use the Github default one for python and then delete all the sections we don't use (Jupyter, ipython, sphinx etc):
https://github.com/github/gitignore/blob/master/Python.gitignore
OK, I followed your recommendation and used the github one.
I guess could optimize it down but is that a long term maintainability issue as things come and go in this repo?
I think you can safely remove the following sections from the .gitignore:
OK, I made some changes to gitignore.
I can slice the PR some different ways if that's a blocker - e.g. agenttest.py only, other changes only?
Yip slice it up into a few different PRs to make it easier to review, I think one for:
OK I will close this 1 PR and create 5 new PRs.
6 apologies I counted incorrectly.
… tests, add example cert instructions.