faucetsdn / faucetagent

gNMI agent for faucet configuration
5 stars 2 forks source link

Use requirements.txt, add pytype, add use of temporary directories in… #42

Closed anarkiwi closed 4 years ago

anarkiwi commented 4 years ago

… tests, add example cert instructions.

anarkiwi commented 4 years ago

Thanks Bob. How about 2 PRs, one that has only changes to agenttest.py and another that adds requirements.txt etc?

Re .gitignore - it's true, this does accumulate stuff over time - I guess as different people have different environments and different IDEs etc. I can optimize it for today for sure, but I don't know a way to ensure it stays small over time?

gizmoguy commented 4 years ago

Regarding gitignore, you probably just want to use the Github default one for python and then delete all the sections we don't use (Jupyter, ipython, sphinx etc):

https://github.com/github/gitignore/blob/master/Python.gitignore

anarkiwi commented 4 years ago

OK, I followed your recommendation and used the github one.

I guess could optimize it down but is that a long term maintainability issue as things come and go in this repo?

gizmoguy commented 4 years ago

I think you can safely remove the following sections from the .gitignore:

anarkiwi commented 4 years ago

OK, I made some changes to gitignore.

I can slice the PR some different ways if that's a blocker - e.g. agenttest.py only, other changes only?

gizmoguy commented 4 years ago

Yip slice it up into a few different PRs to make it easier to review, I think one for:

anarkiwi commented 4 years ago

OK I will close this 1 PR and create 5 new PRs.

anarkiwi commented 4 years ago

6 apologies I counted incorrectly.