fecgov / fecfile-validate

Other
9 stars 2 forks source link

Spec Verification Script Maintenance #284

Closed Elaine-Krauss-TCG closed 10 months ago

Elaine-Krauss-TCG commented 11 months ago

Acceptance Criteria

Working with the Spec Verification script, ensure that the JSON schema files match the Spec Update excel sheets. Running the script with each of the five Spec Update .xlsx files should result in zero errors. This will likely require a combination of updates to the spec verification script, the json schema files, and possibly (with assistance from the BA's) the excel sheets.

Additionally, with each Spec Update excel file, there may be sheets that can't be matched to a JSON schema file. This is expected for sheets that haven't been implemented yet, but these warnings should be investigated to make sure that there isn't a mismatch in naming. The Spec Verification script looks for a JSON schema file with a filename that matches Cell A2 on each sheet, such as in the example below: Private Zenhub Image

Schedule A

Sch A file Current Status: 57 errors between 49 sheets. 1 sheet that can't be matched to a JSON schema file.

Schedule B

Sch B file Current Status: 33 errors between 11 sheets. 1 sheet that can't be matched to a JSON schema file.

Schedule C (Not verified before)

Sch C file Current Status: 91 errors between 3 sheets. 3 sheets that can't be matched to JSON schema files.

Schedule D (Not verified before)

Sch D file Current Status: 18 errors in 1 sheet.

Schedule E (Not verified before)

Sch E file Current Status: 99 errors in 3 sheets. 9 sheets that can't be matched to JSON schema files.

Example of the script being run: Private Zenhub Image

QA Notes

With changes to the JSON schema files, the behavior of individual transaction fields might be changed, depending on the errors being fixed in this ticket. If the dev working this ticket changes the minimum/maximum length, requirement, regex pattern, etc. of a field, they should note the transaction, field, and change in a comment.

DEV Notes

From the root fecfile-validate directory, run python spec_verification [.xlsx file] to check for errors. This needs to be run separately with each of the five spec update sheets listed below.

Design

null

mjtravers commented 10 months ago

This ticket is a duplicate of https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/gh/fecgov/fecfile-validate/291

Closing