search

fedora-infra / freeipa-fas

IPA schema extensions for FAS
GNU General Public License v3.0
12 stars 16 forks source link

Add group attributes #104

Closed abompard closed 4 years ago

abompard commented 4 years ago

Fixes #7

I kept the URL field multi-valued, because I suppose groups could have multiple URLs but maybe that's not the case (WDYT @ryanlerch ?)

I'm not entirely sure about the filter that turns IRC channel names into the draft that @tiran referred to, but it seems to work.

Since attributes are defined independently from objectclasses, I wonder if it would not be better to use a single "fasIRC" attribute definition for both users and groups. What's the best practices like, Christian?

abompard commented 4 years ago

Hey @tiran, I'm made some changes, not sure you got notified by Github (not to be pushy ;-) )

tiran commented 4 years ago

@abompard I have to find some time to test the change. The code duplication is bothering me, too. There might be a better way to it correctly.

tiran commented 4 years ago

@abompard Please review my update on your PR.

I'm sorry for the delay and confusion. I misunderstood a change in your code and gave you false information.

tiran commented 4 years ago

Mailing list and IRC channel are multi-valued in Python code but SINGLE-VALUE in LDAP schema.