Make it possible to choose the fasgroup type in the UI

fedora-infra / freeipa-fas

IPA schema extensions for FAS

GNU General Public License v3.0

12 stars 16 forks source link

Make it possible to choose the fasgroup type in the UI #108

Closed abompard closed 4 years ago

abompard commented 4 years ago

add a checkbox on the group add dialog
add an action to convert a generic group to a fasgroup

It's very hackish because I'm touching JS stuff that I'm not sure about. I tried to make the "FAS group" checkbox editable, but it does not seem to work. It also seems that converting to a FAS group is a one-way street, I don't see a way to convert back, but maybe we don't need to.

Fixes #102

tiran commented 4 years ago

FAS group checkbox is always disabled in the group settings tab.
I don't see a make FAS group in the group settings action dropdown
There is no FAS group option in the group adder dialog.

abompard commented 4 years ago

* `FAS group` checkbox is always disabled in the group settings tab.

Yes, I have not found a way to make it not disabled. I think it's because the fasgroup "attribute" of group isn't really an LDAP attribute, but I'm not sure.

* I don't see a `make FAS group` in the group settings action dropdown
* There is no `FAS group` option in the group adder dialog.

Hmm, those should be there. I see them in my local vagrant install. Maybe a cache problem? Do you get JS errors in the console?

tiran commented 4 years ago

PEBKAC, looks like I did a mistake while syncing and installing the updated JS files. I can now see the FAS group checkbox in adder and make FAS group action.