search

fedora-infra / freeipa-fas

IPA schema extensions for FAS
GNU General Public License v3.0
12 stars 16 forks source link

Add missing semicolon #112

Closed tiran closed 4 years ago

tiran commented 4 years ago 
$ make lint
ui/js/plugins/groupfas/groupfas.js(76): lint warning: missing semicolon
            IPA.group.entity_spec.adder_dialog["$factory"] = IPA.fasgroup_adder_dialog;

Signed-off-by: Christian Heimes cheimes@redhat.com

abompard commented 4 years ago

Ah, that's funny, I removed it because eslint told me it was unneccessary. What config do you use with jsl ?

tiran commented 4 years ago

Ah, that's funny, I removed it because eslint told me it was unneccessary. What config do you use with jsl ?

Just the standard configuration jsl -nologo -nosummary -process ui/js/plugins/groupfas/groupfas.js

abompard commented 4 years ago

Replaced jsl with eslint.