search

fedora-infra / freeipa-fas

IPA schema extensions for FAS
GNU General Public License v3.0
12 stars 16 forks source link

Add Pronoun field as simple freeform string #134

Closed ryanlerch closed 3 years ago

ryanlerch commented 3 years ago

This adds a new FAS attribute for being able to set a user's preferred pronoun(s)

Fixes: fedora-infra/noggin#220

Signed-off-by: Ryan Lerch rlerch@redhat.com

tiran commented 3 years ago

My old PR #97 also includes a blocklist and a new command for findung users with pronouns that deviate from a list of common pronounces. The command could help with moderation.

ryanlerch commented 3 years ago

Oh, a command to help with pronouns would be a nice thing to add here.

Not sure about the blocklist on the IPA side, however. We don't really have blocklists for any other fields (including names, for example), and nore sure if the maintence burden of maintaining this list here in code is a good idea or not.

ryanlerch commented 3 years ago

fedora-infra/noggin#220 also has a bit more recent discussion on this too, FWIW

abompard commented 3 years ago

I think I'd prefer to keep the amount of code in freeipa-fas to the minimum, because that's the code that we know the less, written for an API that we don't have so much documentation for and where we can't have unit tests (if I recall correctly). So I'd rather have a freeform field defined for now and go with the recent comments on fedora-infra/noggin#220 (just report users who abuse the field, not trying to block them premptively).