search

feedhenry / negotiator

Apache License 2.0
2 stars 3 forks source link

add support for configuring apps with ups push applications so the se… #30

Closed maleck13 closed 7 years ago

maleck13 commented 7 years ago

…rver side can send push

So the implementation here follows the following pattern. When a cloud app is deployed to an environment, negotiator asks UPS for a list of push applications. It then writes these to a configmap and mounts them into the cloud app for it to use. If a new push app is created then the app will need to be redeployed to pick up the changes.

I have tested I can read the config map from the cloud app but haven't yet tried with a real app.

Longer term it would make sense to have negotiator create a separate user in UPS as currently we are using the admin user

ping @philbrookes

philbrookes commented 7 years ago

tests failing: ups_configure_test.go:186: did not expect an error but got failed to FindServiceByLabel during PushUpsConfigure

maleck13 commented 7 years ago

@philbrookes going to merge this. If you want to test it locally you can do the following. Create an environment Deploy mysql and ups create an app in ups ui deploy a cloud app the cloud app will have an env var UPS_SERVICE_HOST and UPC_CONIFIG_PATH The cloud app will have a mounted configmap ups-client-config also if you look at the configmap ups-client-config it will have the configuration needed for the app I ran this for @luigizuccarelli @jasonmadigan