feedhenry / negotiator

Apache License 2.0
2 stars 3 forks source link

add os template and docker file #5

Closed maleck13 closed 7 years ago

maleck13 commented 7 years ago

@philbrookes wanna give this a try when you get chance

maleck13 commented 7 years ago

fixed lol

On Fri, Dec 2, 2016 at 2:48 PM, philbrookes notifications@github.com wrote:

@philbrookes commented on this pull request.

In README.md https://github.com/feedhenry/negotiator/pull/5#pullrequestreview-11172712 :

@@ -56,4 +56,24 @@ sysHandler.go


 make test-unit
+```
+
+## build and publish
+
+```
+env GOOS=linux go build .
+
+docker build -t rhmap/negotiator:0.0.1 . ##change build number

Looks like the Dockerfile wasn't commited?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/feedhenry/negotiator/pull/5#pullrequestreview-11172712>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASl9J2NXshKqINc6zBgQKNECV-Kwy-7ks5rEC_NgaJpZM4LB8Df>
.
philbrookes commented 7 years ago

If you rebase on master, the builds will pass now.