Update introduction.adoc

thomas-saigre commented 1 year ago

Add json specifications for boundaries conditions also minor typo fixes

@prudhomm @vincentchabannes can you please review that this additions are corrects ? I'm not sure in particular of expr1 and expr2 for Robin conditions

[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you fixed a Bug ?
[ ] Have you added the documentation of the example or benchmark ?
[ ] Have you successfully run the example or benchmark?
[ ] Have you documented the results?
[ ] Have you added the images to the documentation?
[ ] Have you added the vtkjs files for 3D visualization in the documentation?
[ ] Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr

prudhomm commented 1 year ago

@thomas-saigre I propose some minor changes

prudhomm commented 1 year ago

@thomas-saigre @vincentchabannes the PR deploy using netlify should appear any time soon

netlify[bot] commented 1 year ago

Deploy Preview for toolboxes-dashing-twilight-9661e1 failed.

Name	Link
Latest commit	1b2c287b1eaae7ee28deb8a8d0b1f729db928298
Latest deploy log	https://app.netlify.com/sites/toolboxes-dashing-twilight-9661e1/deploys/650c38f856c19f00088dd076

prudhomm commented 1 year ago

screenshot

@thomas-saigre please could you codeadd some explanation for initial conditions as well ?

Browser metadata

``` Path: /toolboxes/latest/cfpdes/manual/ Browser: Chrome 115.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 961 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-180--dashing-twilight-9661e1.netlify.app%2Ftoolboxes%2Flatest%2Fcfpdes%2Fmanual%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=115.0&resolution=1728x961&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

prudhomm commented 1 year ago

screenshot

perhaps a good idea to have different kind of conditions for different border to examplify ?

Browser metadata

``` Path: /toolboxes/latest/cfpdes/manual/ Browser: Chrome 115.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 961 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-180--dashing-twilight-9661e1.netlify.app%2Ftoolboxes%2Flatest%2Fcfpdes%2Fmanual%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=115.0&resolution=1728x961&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

prudhomm commented 1 year ago

screenshot

perhaps add a comment that this will be considered a non-linear condition due to the presence of heat_T``code ? an alternative to avoid that is to use heat_T_rt (@vincent is this correct?) so that heat_T from previous iteration is used(time or non-linear)

Browser metadata

``` Path: /toolboxes/latest/cfpdes/manual/ Browser: Chrome 115.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 961 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-180--dashing-twilight-9661e1.netlify.app%2Ftoolboxes%2Flatest%2Fcfpdes%2Fmanual%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=115.0&resolution=1728x961&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

prudhomm commented 1 year ago

screenshot

stress out that Robin provide a linear boundary condition so term implying non-linearity cannot be used. Again same trick with _rt (remove trial) could be used to avoid that

Browser metadata

``` Path: /toolboxes/latest/cfpdes/manual/ Browser: Chrome 115.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 961 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-180--dashing-twilight-9661e1.netlify.app%2Ftoolboxes%2Flatest%2Fcfpdes%2Fmanual%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=115.0&resolution=1728x961&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

feelpp / toolbox