search

feelpp / toolbox

:hammer: Feel++ Toolbox Examples
https://feelpp.github.io/toolbox/
GNU General Public License v3.0
6 stars 11 forks source link

Add spring CFD example #3

Closed prudhomm closed 6 years ago

prudhomm commented 6 years ago

the example is in angiotk repo

prudhomm commented 6 years ago

the documentation is now properly generated http://docs.feelpp.org/angiotk/0.1/centerlines/spring/

prudhomm commented 6 years ago

@francoisdh now the mesh generation explanation go in angiotk and the spring cfd #3 and csm #4 go in toolbox. They will need to be linked of course. The mesh of the spring is uploaded to girder

celineCQ commented 6 years ago

I'm confused. Shouldn't the comment about the angiotk doc be in the angiotk issue, linked here by the dependencies, that block this issue ? Cause I've been working on the toolbox & toolbox doc and now I'm not sure anymore of what remains to be done.

prudhomm commented 6 years ago

@celineCQ angiotk is only responsible for the mesh generation and is done (code+docs with antora) in feelpp/angiotk, the CFD and CSM parts are in feelpp/toolbox (note that there some docs in angiotk for them already). If you are already done with the code+doc then awesome! follow the steps here: http://docs.feelpp.org/contribute/latest/#_documentation_setup

prudhomm commented 6 years ago

However in the angiotk documentation we link the mesh generation doc to the CFD/CSM example and vice et versa so that the user can be from one another easily/quickly

celineCQ commented 6 years ago

I'm not done yet, obviously, only made the initial push of the branch with barely anything in it, I was just making sure the work wasn't going to be done twice.

prudhomm commented 6 years ago

I renamed https://github.com/feelpp/angiotk/issues/33 to be more explicit ;)

celineCQ commented 6 years ago

Now waiting for the angio tk docs to be online (for reference) & for final mesh to be put on girder. I also plan on changing the .png file for another vtkjs visualisation, would that be okay ?