Closed pieter61 closed 8 months ago
He Joe,
Something was wrong with de DKIM2 property, so i added a JsonProperty attribute to fix it. After creating PR the test pipeline went wrong, because the API key is not filled.
Can you complete the PR and update the nuget? https://github.com/feinoujc/Mandrill.net/pull/233 [https://opengraph.githubassets.com/1ad505c0e09ae0256b344d866d87e84092e4ccf26450814b87300548accea8d2/feinoujc/Mandrill.net/pull/233]https://github.com/feinoujc/Mandrill.net/pull/233 Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.nethttps://github.com/feinoujc/Mandrill.net/pull/233 Mailchimp Transactional (Mandrill) api client for .NET - Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.net github.com
Best regards, Pieter de Jong
Van: Joe Feinour @.> Verzonden: vrijdag 16 februari 2024 14:49 Aan: feinoujc/Mandrill.net @.> CC: pieter61 @.>; Author @.> Onderwerp: Re: [feinoujc/Mandrill.net] Added dkim2 and dmarc (PR #220)
@feinoujc approved this pull request.
Thanks!
— Reply to this email directly, view it on GitHubhttps://github.com/feinoujc/Mandrill.net/pull/220#pullrequestreview-1885203832, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADNO7EVV3USGP5Z4IZTRCZTYT5PWDAVCNFSM6AAAAABDKPQWN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBVGIYDGOBTGI. You are receiving this because you authored the thread.Message ID: @.***>
He Joe,
Something was wrong with de DKIM2 property, so i added a JsonProperty attribute to fix it. After creating PR the test pipeline went wrong, because the API key is not filled.
Can you complete the PR and update the nuget? https://github.com/feinoujc/Mandrill.net/pull/233 [https://opengraph.githubassets.com/1ad505c0e09ae0256b344d866d87e84092e4ccf26450814b87300548accea8d2/feinoujc/Mandrill.net/pull/233]https://github.com/feinoujc/Mandrill.net/pull/233 Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.nethttps://github.com/feinoujc/Mandrill.net/pull/233 Mailchimp Transactional (Mandrill) api client for .NET - Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.net github.com
Best regards, Pieter de Jong
Van: Joe Feinour @.> Verzonden: vrijdag 16 februari 2024 14:49 Aan: feinoujc/Mandrill.net @.> CC: pieter61 @.>; Author @.> Onderwerp: Re: [feinoujc/Mandrill.net] Added dkim2 and dmarc (PR #220)
@feinoujc approved this pull request.
Thanks!
— Reply to this email directly, view it on GitHubhttps://github.com/feinoujc/Mandrill.net/pull/220#pullrequestreview-1885203832, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADNO7EVV3USGP5Z4IZTRCZTYT5PWDAVCNFSM6AAAAABDKPQWN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBVGIYDGOBTGI. You are receiving this because you authored the thread.Message ID: @.***>