ferram4 / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program
Other
238 stars 131 forks source link

Compatibility with remoteTech 2 #154

Open msnbcorp opened 7 years ago

msnbcorp commented 7 years ago

It seems that the compatibility problem on surface control with remote tech 2 is not fixed in last version. It delete somme of surface control.

ferram4 commented 7 years ago

I am not aware of any compatibility problems with RemoteTech. I need reproduction steps, logs, and a full description of what the issue actually is.

lamont-granquist commented 7 years ago

I'm guessing its this:

https://www.reddit.com/r/Kos/comments/4mocue/bad_cooked_steering_with_far/

(there's two bugs talked about in that thread -- I'm not talking about the busted voxellization with CLS bug which was fixed -- talking about the negative torque bug)

Do not quote me on this but I think its likely bugs in RT/kOS where they need to be doing available torque computations using 6-vectors, not 3-vectors, e.g.:

https://github.com/MuMech/MechJeb2/blob/master/MechJeb2/VesselState.cs#L569-L572

IIRC, since ITorqueProvider's are 3-vectors that makes using ITorqueProvider for anything non-symmetrical is problematic, which is a bug in KSP core.

HTH