search

ferram4 / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program
Other
238 stars 131 forks source link

Prop spinners voxelized #178

Closed KSAMissionCtrl closed 7 years ago

KSAMissionCtrl commented 7 years ago

Using the latest Dev Build from 3/25

I'm wondering if FAR is voxeling prop spinners while in flight. When I build an aircraft in the SPH and attach a propeller engine like this one from SXT, the voxelization comes out fine:

ksp_x64 exe_dx9_20170331_184706

However if I just exit the SPH and return, when I re-display the voxels I get this:

ksp_x64 exe_dx9_20170331_184629

Further evidence is my plane flying slower in v1.2.2 than it did in v1.1.3. I see the engine part lit up a lot in drag viz (it flickers in and out mostly, but is doing it constantly all the time):

ksp_x64 exe_dx9_20170331_185004

Versus the same aircraft in level flight under v1.1.3 of KSP (no drag appears on the engine at all unless pulling maneuvers):

screenshot2

ferram4 commented 7 years ago

Have you installed the new https://github.com/ferram4/Ferram-Aerospace-Research/blob/KSP_update/GameData/FerramAerospaceResearch/FARPartModuleTransformExceptions.cfg config to GameData/FerramAerospaceResearch? Specifying modules to not be voxelized is specified in config files for the v1.2.2 build, rather than in the code directly for the v1.1.3 builds.

KSAMissionCtrl commented 7 years ago

Yup, I do indeed have that file installed from the 3/25 dev build. Are you saying I will need to edit that file to fix this problem or that this is a problem you expected that file to fix and that's why you're checking if I may not have it?

ferram4 commented 7 years ago

I expected that it might fix the problem. Okay, so then that means that's a serious bug to look into.

KSAMissionCtrl commented 7 years ago

anything you need from me, just let me know!

ferram4 commented 7 years ago

Alright, please try the latest dev build. You should only need the new dll and it should work.

KSAMissionCtrl commented 7 years ago

egggggcellent. Replacing only the DLL fixed the issue - at least to the point where everything I posted above I could no longer get to happen, only a little time available to test at the moment.

ferram4 commented 7 years ago

Well, then I'm closing this as fixed.