search

fiatjaf / nocomment

See a demo at https://fiatjaf.com/nostr.html
https://nocomment.pages.dev/embed.js
136 stars 17 forks source link

[Feature Request] Add custom noteid when embedding nocomment so that comments show up under custom note #11

Closed InnocuousFinch closed 1 year ago

InnocuousFinch commented 1 year ago

Use case: I want to make a post on Nostr showing off the new guide I just wrote, which has nocomment embedded added to the bottom of it: https://sovrnbitcoiner.com/receiving-self-sovereign-zaps/

It would be cool if the comments from nocomment would display replies directly under the post I make to share the guide. And that comments made to my post would show up under the nocomment embed on the guide.

fiatjaf commented 1 year ago

Here it is: https://github.com/fiatjaf/nocomment/commit/d72f36b93dbb2dfed460d26a6ddfc633717f3a62

It's deployed already, but it is not tested. If it's broken please fix it for me.

BitcoinQnA commented 1 year ago

I think this change borked the whole thing @fiatjaf.

I've checked the 3 instances I know running this (including your site and none are working.

I'd love to have the knowledge to be able to fix, but I do not. So bringing it to your attention is the most I can do currently.

fiatjaf commented 1 year ago

Thank you. I think it is fixed now.